Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak implementation of overflow checking assertions #109234

Merged
merged 1 commit into from
Mar 18, 2023
Merged

Tweak implementation of overflow checking assertions #109234

merged 1 commit into from
Mar 18, 2023

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Mar 16, 2023

Extract and reuse logic controlling behaviour of overflow checking assertions instead of duplicating it three times.

r? @cjgillot

@tmiasko
Tweak implementation of overflow checking assertions
27b430b 
Extract and reuse logic controlling behaviour of overflow checking
assertions instead of duplicating it three times.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 16, 2023
@rustbot
Copy link
Collaborator

rustbot commented Mar 16, 2023

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

This PR changes MIR

cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @celinval, @vakaras

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

The Miri subtree was changed

cc @rust-lang/miri

@oli-obk
Copy link
Contributor

oli-obk commented Mar 16, 2023

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 16, 2023
@bors
Copy link
Contributor

bors commented Mar 16, 2023

⌛ Trying commit 27b430b with merge 05f44905f0257f9220a919edf4db5133a7833897...

@bors
Copy link
Contributor

bors commented Mar 17, 2023

☀️ Try build successful - checks-actions
Build commit: 05f44905f0257f9220a919edf4db5133a7833897 (05f44905f0257f9220a919edf4db5133a7833897)

@rust-timer

This comment has been minimized.

Sign in to view
@cjgillot
Copy link
Contributor

Thanks!
r=me if perf is clean.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (05f44905f0257f9220a919edf4db5133a7833897): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.5% [0.4%, 0.8%] 4
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.5% [-0.5%, -0.5%] 2
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.2% [-0.5%, 0.8%] 6

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.5% [-0.5%, -0.5%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.5% [-0.5%, -0.5%] 1

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 18, 2023
@tmiasko
Copy link
Contributor Author

tmiasko commented Mar 18, 2023

@bors r=cjgillot rollup

@bors
Copy link
Contributor

bors commented Mar 18, 2023

📌 Commit 27b430b has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 18, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 18, 2023
@bors
Auto merge of rust-lang#109303 - matthiaskrgr:rollup-usj4ef5, r=matth…
f177b7c 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#107416 (Error code E0794 for late-bound lifetime parameter error.)
 - rust-lang#108772 (Speed up tidy quite a lot)
 - rust-lang#109193 (Add revisions for -Zlower-impl-trait-in-trait-to-assoc-ty fixed tests)
 - rust-lang#109234 (Tweak implementation of overflow checking assertions)
 - rust-lang#109238 (Fix generics mismatch errors for RPITITs on -Zlower-impl-trait-in-trait-to-assoc-ty)
 - rust-lang#109283 (rustdoc: reduce allocations in `visibility_to_src_with_space`)
 - rust-lang#109287 (Use `size_of_val` instead of manual calculation)
 - rust-lang#109288 (Stabilise `unix_socket_abstract`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a48d83d into rust-lang:master Mar 18, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 18, 2023
@tmiasko tmiasko deleted the overflow-checks branch March 27, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cjgillot cjgillot

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.
7 participants
@tmiasko @rustbot @oli-obk @rust-timer @bors @cjgillot @Aurel300