rustdoc: Ensure that all files have been written on windows before exiting #109134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #109060.
I originally wanted to use
rayon::in_scope
to ensure that all threads would be waited once we're out, however it adds to many restrictions and requires to keep a&rayon::Scope
around, making it quite tricky to use unfortunately.So what remains is the classical ways to sync with threads. With this implementation though, if a thread crashes for whatever reason, we simply won't know and rustdoc will wait forever, which is pretty bad.
So if anyone has suggestions for improving this, it'd be very welcome.
In the meantime:
r? @ehuss