Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 10 pull requests #109012

Closed
wants to merge 25 commits into from

Commits on Jan 31, 2023

  1. Fix vec_deque::Drain FIXME

    Sp00ph committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    8ca25b8 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2023

  1. Configuration menu
    Copy the full SHA
    1e114a8 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2023

  1. Changes according to review

    Sp00ph committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    acc876e View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2023

  1. Honor current target when checking conditional compilation values

    This is fixed by simply using the currently registered target in the
    current session. We need to use it because of target json that are not
    by design included in the rustc list of targets.
    Urgau committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    3455d66 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2023

  1. Move __thread_local_inner to sys

    Move __thread_local_inner macro in crate::thread::local to crate::sys.
    Currently, the tidy check does not fail for `library/std/src/thread/local.rs` even though it contains platform specific code. This is beacause target_family did not exist at the time the tidy checks were written [1].
    
    [1]: rust-lang#105861 (comment)
    
    Signed-off-by: Ayush Singh <ayushsingh1325@gmail.com>
    Ayush1325 committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    ffa9019 View commit details
    Browse the repository at this point in the history
  2. Split __thread_local_inner macro

    Split the __thread_local_inner macro to make it more readable. Also move
    everything to crate::sys::common::thread_local.
    
    Signed-off-by: Ayush Singh <ayushsingh1325@gmail.com>
    Ayush1325 committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    45d5021 View commit details
    Browse the repository at this point in the history
  3. rustdoc: Don't crash on crate references in blocks

    This is a regression from rust-lang#94857.
    adrianheine committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    c84c5e6 View commit details
    Browse the repository at this point in the history
  4. Add note when matching token with nonterminal

    The current error message is _really_ confusing.
    Noratrieb committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    3dee463 View commit details
    Browse the repository at this point in the history
  5. Moved thread_local implementation to sys::common

    This allows removing all the platform-dependent code from `library/std/src/thread/local.rs` and `library/std/src/thread/mod.rs`
    
    Signed-off-by: Ayush Singh <ayushsingh1325@gmail.com>
    Ayush1325 committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    5828910 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e0d9170 View commit details
    Browse the repository at this point in the history
  7. rustdoc: sort deprecated items lower in search

    serialize `q` (`itemPaths`) sparsely
    overall 4% reduction in search index size
    pitaj committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    d2e4b59 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    83da9a8 View commit details
    Browse the repository at this point in the history
  9. Simplify typeck entry.

    cjgillot committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    391ef47 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    bb37b60 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    2f166d1 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2023

  1. Rollup merge of rust-lang#106276 - Sp00ph:unify_slice_ranges, r=the8472

    Fix `vec_deque::Drain` FIXME
    
    In my original `VecDeque` rewrite, I didn't use `VecDeque::slice_ranges` in `Drain::as_slices`, even though that's basically the exact use case for `slice_ranges`. The reason for this was that a `VecDeque` wrapped in a `Drain` actually has its length set to `drain_start`, so that there's no potential use after free if you `mem::forget` the `Drain`. I modified `slice_ranges` to accept an explicit `len` parameter instead, which it now uses to bounds check the given range. This way, `Drain::as_slices` can use `slice_ranges` internally instead of having to basically just copy paste the `slice_ranges` code. Since `slice_ranges` is just an internal helper function, this shouldn't change the user facing behavior in any way.
    matthiaskrgr committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    3c7f2e1 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#107629 - pitaj:rustdoc-search-deprecated, r…

    …=jsha
    
    rustdoc: sort deprecated items lower in search
    
    closes rust-lang#98759
    
    ### Screenshots
    
    `i32::MAX` show sup above `std::i32::MAX` and `core::i32::MAX`
    ![image](https://user-images.githubusercontent.com/803701/216725619-40afb7b0-e984-4a2e-ab5b-a95b24736b0e.png)
    If just searching for `min`, the deprecated results show up far below other things:
    ![image](https://user-images.githubusercontent.com/803701/216725672-e4325d37-9bfe-47eb-a1fe-0e57092aa811.png)
    one page later
    ![image](https://user-images.githubusercontent.com/803701/216725932-cd1c4a42-d527-44fb-a4ab-5a6d243659cc.png)
    
    ~~And, as you can see, the "Deprecation planned" message shows up in the search results. The same is true for fully-deprecated items like `mem::uninitialized`:
    ![image](https://user-images.githubusercontent.com/803701/216726268-1657e77a-563f-45a0-85a7-3a0cf4d66d6f.png)~~
    
    Edit: the deprecation message change was removed from this PR. Only the sorting is changed.
    matthiaskrgr committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    7ddcddf View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#108711 - Nilstrieb:nt-note, r=petrochenkov

    Add note when matching token with nonterminal
    
    The current error message is _really_ confusing. The implementation is slightly hacky, but not that much more hacky than all this nonterminal stuff..
    
    r? `@petrochenkov`
    matthiaskrgr committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    34edc59 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#108757 - clubby789:askama-move, r=notriddle…

    …,jsha,GuillaumeGomez
    
    rustdoc: Migrate `document_item_info` to Askama
    
    https://rust-lang.zulipchat.com/#narrow/stream/266220-rustdoc/topic/rustdoc.20allocations.20are.20slow
    
    Hoping to piece-by-piece migrate things to template. Had a few failed attempts at more complex parts of the code, so this is just a start.
    matthiaskrgr committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    366a3ee View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#108784 - clubby789:askama-sidebar, r=jsha,G…

    …uillaumeGomez
    
    rustdoc: Migrate sidebar rendering to Askama
    
    cc rust-lang#108757
    
    Renders the sidebar for documentation using an Askama template
    matthiaskrgr committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    7be58e7 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#108927 - Ayush1325:pal-cleanup, r=workingju…

    …bilee
    
    Move __thread_local_inner to sys
    
    Move `__thread_local_inner` macro in `crate::thread::local` to `crate::sys`. Initially, I was thinking about removing this macro completely, but I could not find a way to create the generic statics without macros, so in the end, I just moved to code around.
    
    This probably will need a rebase once rust-lang#108917 is merged
    
    r? `@workingjubilee`
    matthiaskrgr committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    0b900cb View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#108949 - Urgau:check-cfg-target-json, r=oli…

    …-obk
    
    Honor current target when checking conditional compilation values
    
    This is fixed by simply using the currently registered target in the current session. We need to use it because of target json that are not by design included in the rustc list of targets.
    
    Fixes rust-lang#108941
    matthiaskrgr committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    5dd7770 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#108950 - cjgillot:inherit-less, r=compiler-…

    …errors
    
    Directly construct Inherited in typeck.
    
    Using `InheritedBuilder` + a closure does not seem necessary any more.
    
    + a few opportunistic simplifications to typeck entry point.
    matthiaskrgr committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    1cccda3 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#108988 - adrianheine:crate-reference-block,…

    … r=petrochenkov
    
    rustdoc: Don't crash on `crate` references in blocks
    
    This is a regression from rust-lang#94857.
    matthiaskrgr committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    88554d1 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#108997 - tgross35:patch-1, r=JohnTitor

    Change text -> rust highlighting in sanitizer.md
    
    Not sure why this has syntax highlighting turned off, but it doesn't need to be
    
    Relevant page: https://doc.rust-lang.org/beta/unstable-book/compiler-flags/sanitizer.html
    matthiaskrgr committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    d63346c View commit details
    Browse the repository at this point in the history