Rollup of 9 pull requests #108977
Merged
Rollup of 9 pull requests #108977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he sign positive aspect)
…ar, r=lcnr Unconstrained terms should account for infer vars being equated Follow-up from the canonicalization PR, wanted to break this one out so I can approve the other PR. r? `@lcnr`
…eexport, r=notriddle Rustdoc: don't hide anonymous reexport Fixes rust-lang#108931. From rust-lang#108931, it appears that having anonymous re-exports for traits is actually used in some places, so instead of hiding them automatically, we should prevent them to be ever inlined. r? `@notriddle`
…-errors Add myself to compiler reviewers list
…using-hir-id, r=compiler-errors Make some report and emit errors take DefIds instead of BodyIds Breaking off from rust-lang#108915 r? `@compiler-errors`
Document the resulting values produced when using `From<bool>` on floats Have the documentation of the implementation of `From<bool>` on `f32` and `f64` indicate the output values (`0.0` for `false` and `1.0` for `true`). closes rust-lang#108939
Make ptr::from_ref and ptr::from_mut in rust-lang#106116 const. As per rust-lang#106116 (comment)
…cjgillot Remove `body_def_id` from `Inherited` We can just use the body id from the obligation cause. Follow-up to rust-lang#108945, only my commit is relevant. r? `@cjgillot` cc `@spastorino`
…albertlarsan68 only call git on git checkouts during bootstrap fixes rust-lang#108959
…jubilee
Fix the docs for pointer method with_metadata_of
The name of the argument to `{*const T, *mut T}::with_metadata_of` was changed from `val` to `meta` recently, but the docs weren't updated to match.
Relevant pull request: rust-lang#103701
rustbot
added
A-meta
|
@bors r+ rollup=never p=9 |
bors
added
S-waiting-on-bors
|
@bors r+ rollup=never p=9 |
|
💡 This pull request was already approved, no need to approve it again.
|
|
⌛ Testing commit df74b70 with merge 5de5d36e03bf0b43e71a31dcc7d2e8869bb40c74... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: previous master: d5833423a0 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (35a0961): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
From<bool>on floats #108946 (Document the resulting values produced when usingFrom<bool>on floats)body_def_idfromInherited#108960 (Removebody_def_idfromInherited)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup