feat: impl better help for .poll() not found on impl Future
#108731
Merged
+34
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Umm, CI failing isn't my fault? Don't know what to do about that. |
|
I restarted the checks. Hopefully they work this time. |
Ezrashaw
force-pushed
the
pin-suggestion-on-impl-future
branch
from
9f1e2be to
aaaffa9
Compare
|
@compiler-errors Feedback implemented. |
|
@bors r+ |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 7, 2023
…ture, r=petrochenkov feat: impl better help for `.poll()` not found on `impl Future` Partially address rust-lang#108572 I'd like to also address suggestions for generalized `Self` parameters as well. That'll be a separate PR.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 7, 2023
Rollup of 7 pull requests Successful merges: - rust-lang#108619 (Remove the option to disable `llvm-version-check`) - rust-lang#108728 (infer: fix and improve comments) - rust-lang#108731 (feat: impl better help for `.poll()` not found on `impl Future`) - rust-lang#108774 (Greatly improve the error messages when `run-make/translation` fails) - rust-lang#108805 (Update askama to 0.12 and improve whitespace control) - rust-lang#108823 (Add tracking issue for cf-protection to unstable book) - rust-lang#108855 (Custom MIR: Support `as` casts) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially address #108572
I'd like to also address suggestions for generalized
Selfparameters as well. That'll be a separate PR.