Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match unmatched backticks in library/ #108688

Merged
merged 1 commit into from
Mar 4, 2023
Merged

Match unmatched backticks in library/ #108688

merged 1 commit into from
Mar 4, 2023

Conversation

est31
Copy link
Member

@est31 est31 commented Mar 3, 2023 •
edited
Loading

Found with GNU grep:

grep -rEn '^(([^`]*`){2})*[^`]*`[^`]*$' library/ | rg -v '\s*[//]?.{1,2}```'

split out from #108685 as per advice.

@rustbot
Copy link
Collaborator

rustbot commented Mar 3, 2023

r? @cuviper

(rustbot has picked a reviewer for you, use r? to override)

@est31
Copy link
Member Author

est31 commented Mar 3, 2023

r? @thomcc as per zulip.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 3, 2023
@rustbot
Copy link
Collaborator

rustbot commented Mar 3, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@jyn514
Copy link
Member

jyn514 commented Mar 3, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 3, 2023

📌 Commit 9994050 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 3, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 3, 2023
@matthiaskrgr
Rollup merge of rust-lang#108688 - est31:backticks_matchmaking_librar…
e2ae18f 
…y, r=jyn514

Match unmatched backticks in library/

Found with GNU grep:

```
grep -rEn '^(([^`]*`){2})*[^`]*`[^`]*$' library/ | rg -v '\s*[//]?.{1,2}```'
```

split out from rust-lang#108685 as per advice.
@matthiaskrgr
Copy link
Member

Hmm might have failed in a rollup, but I'm not seeing how tbh

 Testing filter-crate.js ... OK
Testing fn-forget.js ... OK
Testing from_u.js ... OK
Testing keyword.js ... OK
Testing macro-check.js ... OK
Testing macro-print.js ... OK
Testing never.js ... OK
/checkout/src/tools/rustdoc-js/tester.js:143
                result_v.forEach((value, index) => {
                         ^

TypeError: result_v.forEach is not a function
    at valueCheck (/checkout/src/tools/rustdoc-js/tester.js:143:26)
    at runParser (/checkout/src/tools/rustdoc-js/tester.js:170:9)
    at /checkout/src/tools/rustdoc-js/tester.js:306:20
    at runCheck (/checkout/src/tools/rustdoc-js/tester.js:256:30)
    at runChecks (/checkout/src/tools/rustdoc-js/tester.js:305:16)
    at /checkout/src/tools/rustdoc-js/tester.js:426:23
    at Array.forEach (<anonymous>)
    at main (/checkout/src/tools/rustdoc-js/tester.js:421:45)
    at Object.<anonymous> (/checkout/src/tools/rustdoc-js/tester.js:433:14)
    at Module._compile (internal/modules/cjs/loader.js:999:30)
Testing parser-errors.js ... Build completed unsuccessfully in 0:27:51

https://github.com/rust-lang-ci/rust/actions/runs/4326491891/jobs/7553984409#step:26:36168

please just disregard and rer+ if its spurious or I'm wrong 🙈

@matthiaskrgr
Copy link
Member

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 3, 2023
@matthiaskrgr
Copy link
Member

ah crap sorry, I wanted to comment on a different PR 😄
ETOOMANYPRS

@bors r=jyn514

@bors
Copy link
Contributor

bors commented Mar 3, 2023

📌 Commit 9994050 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 3, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 3, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 3, 2023
@bors
Auto merge of rust-lang#108709 - matthiaskrgr:rollup-j2tjbyx, r=matth…
70adb4e 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#104549 (add -Zexport-executable-symbols to unstable book)
 - rust-lang#108292 (Label opaque type for 'captures lifetime' error message)
 - rust-lang#108540 (Add `Atomic*::from_ptr`)
 - rust-lang#108634 (Add link to component dashboard)
 - rust-lang#108647 (Remove dead pgo.sh file)
 - rust-lang#108678 (Use `Option::as_slice` where applicable)
 - rust-lang#108681 (Improve comments in `needs_process_obligation`.)
 - rust-lang#108688 (Match unmatched backticks in library/)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7a228ce into rust-lang:master Mar 4, 2023
@rustbot rustbot added this to the 1.69.0 milestone Mar 4, 2023
@workingjubilee
Copy link
Member

Please do not land aesthetic commits against the library/portable-simd subtree.

@est31
Copy link
Member Author

est31 commented Apr 23, 2023

@workingjubilee I usually try to avoid doing that (including the other subtrees like rustfmt or clippy). This has slipped through. I am sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thomcc thomcc

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.
8 participants
@est31 @rustbot @jyn514 @bors @matthiaskrgr @workingjubilee @cuviper @thomcc