Highlight whole expression for E0599 #108609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-testsuite
clubby789
force-pushed
the
e0599-highlight
branch
from
8e0e9b2
to
85ca415
Compare
WaffleLapkin
reviewed
Mar 1, 2023
|
Yeah, I agree with @WaffleLapkin on this. There's an |
clubby789
force-pushed
the
e0599-highlight
branch
from
85ca415
to
6c2a952
Compare
|
That looks nicer. I left the compiletest changes because it seems reasonable to ignore textless notes, but I can revert that too |
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 2, 2023
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#108516 (Restrict `#[rustc_box]` to `Box::new` calls) - rust-lang#108575 (Erase **all** regions when probing for associated types on ambiguity in astconv) - rust-lang#108585 (Run compiler test suite in parallel on Fuchsia) - rust-lang#108606 (Add test case for mismatched open/close delims) - rust-lang#108609 (Highlight whole expression for E0599) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #108603
This adds a secondary label to highlight the whole expression leading to the error. It also prevents empty labels being recognised as 'unexpected' by compiletest - otherwise, tests with NOTE annotations would pick up empty labels.
@rustbot label +A-diagnostics