Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: Prevent to have more than one exclamation mark in a search path #108455

Closed

Conversation

GuillaumeGomez
Copy link
Member

Having a!::c doesn't really makes sense as macros can't have associated items. This PR removes this possibility by emitting an error with this syntax.

r? @notriddle

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 25, 2023
@rustbot
Copy link
Collaborator

rustbot commented Feb 25, 2023

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@GuillaumeGomez GuillaumeGomez added the A-rustdoc-search Area: Rustdoc's search feature label Feb 25, 2023
@notriddle
Copy link
Contributor

@GuillaumeGomez #108143 already does this same change, and is in FCP.

@GuillaumeGomez
Copy link
Member Author

Completely forgot about it, my bad! Your PR is also much complete. Closing then!

@GuillaumeGomez GuillaumeGomez deleted the search-exclamation-mark branch February 25, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-search Area: Rustdoc's search feature S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants