Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shrink size of array benchmarks #108023

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Shrink size of array benchmarks #108023

merged 1 commit into from
Feb 14, 2023

Conversation

JulianKnodt
Copy link
Contributor

Might've overdone it with the size of these benchmarks, as there's no need for them to be quite as large.

Fixes #108011

@rustbot
Copy link
Collaborator

rustbot commented Feb 14, 2023

r? @thomcc

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 14, 2023
@rustbot
Copy link
Collaborator

rustbot commented Feb 14, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@workingjubilee
Copy link
Member

The 1MiB default stack size on Windows strikes again.
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 14, 2023

📌 Commit 826abcc has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 14, 2023
@ChrisDenton
Copy link
Member

ChrisDenton commented Feb 14, 2023 •
edited
Loading

The 1MiB default stack size on Windows strikes again.

I keep saying we should increase this to be at the very very least the same as the default for new threads (that section of the docs is a little bit misleading on Windows as the main thread stack size kinda is determined by Rust, if only by omission).

Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Feb 14, 2023
@Dylan-DPC
Rollup merge of rust-lang#108023 - JulianKnodt:smaller_benchmark, r=w…
b8d1547 
…orkingjubilee

Shrink size of array benchmarks

Might've overdone it with the size of these benchmarks, as there's no need for them to be quite as large.

Fixes rust-lang#108011
@Dylan-DPC Dylan-DPC mentioned this pull request Feb 14, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 14, 2023
@matthiaskrgr
Rollup merge of rust-lang#108023 - JulianKnodt:smaller_benchmark, r=w…
d5efe29 
…orkingjubilee

Shrink size of array benchmarks

Might've overdone it with the size of these benchmarks, as there's no need for them to be quite as large.

Fixes rust-lang#108011
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 14, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 14, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 14, 2023
@bors
Auto merge of rust-lang#108052 - matthiaskrgr:rollup-p6r6rnl, r=matth…
6e01157 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#103478 ( Suggest fix for misplaced generic params on fn item rust-lang#103366 )
 - rust-lang#107739 (Check for overflow in evaluate_canonical_goal)
 - rust-lang#108003 (Avoid ICE when the generic_span is empty)
 - rust-lang#108016 ("Basic usage" is redundant for there is just one example)
 - rust-lang#108023 (Shrink size of array benchmarks)
 - rust-lang#108024 (add message to update Cargo.toml when x is changed)
 - rust-lang#108025 (rustdoc: add more tooltips to intra-doc links)
 - rust-lang#108029 (s/eval_usize/eval_target_usize/ for clarity)
 - rust-lang#108035 (Avoid using a dead email address as the main email address)
 - rust-lang#108038 (Remove needless supertrait constraints from Interner projections)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@mina86
Copy link
Contributor

mina86 commented Feb 14, 2023

The 1MiB default stack size on Windows strikes again.

I’m observing the failure on Debian as well so this doesn’t look Windows-specific.

@bors bors merged commit d599be0 into rust-lang:master Feb 14, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 14, 2023
@JulianKnodt JulianKnodt deleted the smaller_benchmark branch February 15, 2023 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thomcc thomcc

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.

array::map_8byte_256byte_256 benchmark causes stack overflow
7 participants
@JulianKnodt @rustbot @workingjubilee @bors @ChrisDenton @mina86 @thomcc