Add `Clause::ConstArgHasType` #107965

BoxyUwU · 2023-02-12T19:57:36Z

Currently the way that we check that a const arg has the correct type for the const param it is an argument for is by setting the expected type of typeck on the anon const of the argument to be the const param's type.

In the future for a potential min_generic_const_exprs we will allow providing const arguments that do not have an associated anon const that can be typeck'd which will require us to actually check that the const argument has the correct type. While it would potentially be possible to just call eq when creating substs this would not work if we support generics of the form const N: T, T (the const parameters type referencing generics declared after itself).

Additionally having ConstArgHasType will allow us to potentially make progress on removing the ty field of Const which may be desirable. Once progress has been made on this, ConstArgHasType will also be helpful in ensuring we do not make mistakes in trait/impl checking by declaring functions with the wrong const parameter types as the checks that the param env is compatible would catch it. (We have messed this up in the past, and with generic const parameter types these checks will get more complex)

There is a document about the types of const generics that may provide some general information on this subject

This PR shouldn't have any impact on whether code compiles or not on stable, it primarily exists to make progress on unstable const generics features that are desirable.

rustbot · 2023-02-12T19:57:41Z

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

BoxyUwU · 2023-02-12T20:04:54Z

@bors try @rust-timer queue

bors · 2023-02-12T20:05:02Z

⌛ Trying commit 68f67579fdf91a0bdd108d513284bc0a9b6b0bdb with merge e660dc534275dfd10344eb9e5571f2003dc9001a...

bors · 2023-02-12T22:20:24Z

☀️ Try build successful - checks-actions
Build commit: e660dc534275dfd10344eb9e5571f2003dc9001a (e660dc534275dfd10344eb9e5571f2003dc9001a)

bors · 2023-02-12T22:20:24Z

☀️ Try build successful - checks-actions
Build commit: e660dc534275dfd10344eb9e5571f2003dc9001a (e660dc534275dfd10344eb9e5571f2003dc9001a)

rust-timer · 2023-02-12T23:37:58Z

Finished benchmarking commit (e660dc534275dfd10344eb9e5571f2003dc9001a): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.3%, 0.3%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.9%	[-4.3%, -0.2%]	6
All ❌✅ (primary)	0.3%	[0.3%, 0.3%]	1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.7%	[2.7%, 2.7%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.7%	[2.7%, 2.7%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

compiler/rustc_hir_analysis/src/collect/predicates_of.rs

BoxyUwU · 2023-02-13T18:34:22Z

r? @compiler-errors although i have not yet had a chance to look over the diff so it probably is a little not great :<

compiler-errors

Thanks @BoxyUwU

r=me after couple of nits

compiler/rustc_hir_analysis/src/collect/predicates_of.rs

compiler/rustc_trait_selection/src/solve/mod.rs

compiler/rustc_trait_selection/src/traits/wf.rs

BoxyUwU · 2023-02-16T12:47:04Z

@bors r=compiler-errors

bors · 2023-02-16T12:47:06Z

📌 Commit dda8defca37ba66a11982511897835e559cd680b has been approved by compiler-errors

It is now in the queue for this repository.

BoxyUwU · 2023-02-17T09:42:44Z

@bors r=compiler-errors

CI failed because the PR making type_of return EarlyBinder merged and I added a call to type_of in this PR

bors · 2023-02-17T09:42:45Z

📌 Commit 90c8d6b has been approved by compiler-errors

It is now in the queue for this repository.

bors · 2023-02-17T11:27:25Z

⌛ Testing commit 90c8d6b with merge f4f5fc3...

bors · 2023-02-17T14:27:22Z

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing f4f5fc3 to master...

bors · 2023-02-17T14:27:22Z

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing f4f5fc3 to master...

rust-timer · 2023-02-17T16:42:44Z

Finished benchmarking commit (f4f5fc3): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.4%, 0.4%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.4%	[0.4%, 0.4%]	1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.4%	[2.4%, 2.4%]	1
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.4%	[2.4%, 2.4%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

…, r=BoxyUwU Suppress copy impl error when post-normalized type references errors Suppress spurious errors from the `Copy` impl validity check when fields have bad types *post*-normalization, instead of just pre-normalization. ---- The const-generics test regressed recently due to rust-lang#107965, cc `@BoxyUwU.` * I think it's because `[_; 0u32]: Copy` now fails to hold because a nested obligation `ConstArgHasType(0u32, usize)` fails. * It's interesting that `[const_error]` shows up in the type only after normalization, though, but I'm pretty sure that it's due to the evaluate call that happens when normalizing unevaluated consts.

…, r=BoxyUwU Suppress copy impl error when post-normalized type references errors Suppress spurious errors from the `Copy` impl validity check when fields have bad types *post*-normalization, instead of just pre-normalization. ---- The const-generics test regressed recently due to rust-lang#107965, cc ``@BoxyUwU.`` * I think it's because `[_; 0u32]: Copy` now fails to hold because a nested obligation `ConstArgHasType(0u32, usize)` fails. * It's interesting that `[const_error]` shows up in the type only after normalization, though, but I'm pretty sure that it's due to the evaluate call that happens when normalizing unevaluated consts.

…, r=BoxyUwU Suppress copy impl error when post-normalized type references errors Suppress spurious errors from the `Copy` impl validity check when fields have bad types *post*-normalization, instead of just pre-normalization. ---- The const-generics test regressed recently due to rust-lang#107965, cc ```@BoxyUwU.``` * I think it's because `[_; 0u32]: Copy` now fails to hold because a nested obligation `ConstArgHasType(0u32, usize)` fails. * It's interesting that `[const_error]` shows up in the type only after normalization, though, but I'm pretty sure that it's due to the evaluate call that happens when normalizing unevaluated consts.

…, r=BoxyUwU Suppress copy impl error when post-normalized type references errors Suppress spurious errors from the `Copy` impl validity check when fields have bad types *post*-normalization, instead of just pre-normalization. ---- The const-generics test regressed recently due to rust-lang#107965, cc ````@BoxyUwU.```` * I think it's because `[_; 0u32]: Copy` now fails to hold because a nested obligation `ConstArgHasType(0u32, usize)` fails. * It's interesting that `[const_error]` shows up in the type only after normalization, though, but I'm pretty sure that it's due to the evaluate call that happens when normalizing unevaluated consts.

…, r=BoxyUwU Suppress copy impl error when post-normalized type references errors Suppress spurious errors from the `Copy` impl validity check when fields have bad types *post*-normalization, instead of just pre-normalization. ---- The const-generics test regressed recently due to rust-lang#107965, cc `````@BoxyUwU.````` * I think it's because `[_; 0u32]: Copy` now fails to hold because a nested obligation `ConstArgHasType(0u32, usize)` fails. * It's interesting that `[const_error]` shows up in the type only after normalization, though, but I'm pretty sure that it's due to the evaluate call that happens when normalizing unevaluated consts.

BoxyUwU force-pushed the add_const_arg_has_type_predicate branch from bef61ae to 68f6757 Compare February 12, 2023 20:04

BoxyUwU added the A-const-generics Area: const generics (parameters and arguments) label Feb 12, 2023

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 12, 2023

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Feb 12, 2023

BoxyUwU force-pushed the add_const_arg_has_type_predicate branch from 68f6757 to 76bf2e9 Compare February 12, 2023 23:44

BoxyUwU commented Feb 13, 2023

View reviewed changes

compiler/rustc_hir_analysis/src/collect/predicates_of.rs Outdated Show resolved Hide resolved

This comment was marked as off-topic.

Sign in to view

BoxyUwU force-pushed the add_const_arg_has_type_predicate branch from 76bf2e9 to 944a84e Compare February 13, 2023 16:33

rustbot assigned compiler-errors Feb 13, 2023

compiler-errors reviewed Feb 16, 2023

View reviewed changes

compiler/rustc_hir_analysis/src/collect/predicates_of.rs Outdated Show resolved Hide resolved

compiler/rustc_trait_selection/src/solve/mod.rs Outdated Show resolved Hide resolved

compiler/rustc_trait_selection/src/traits/wf.rs Outdated Show resolved Hide resolved

BoxyUwU force-pushed the add_const_arg_has_type_predicate branch from 944a84e to dda8def Compare February 16, 2023 12:02

bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 16, 2023

add predicate evaluation logic

90c8d6b

BoxyUwU force-pushed the add_const_arg_has_type_predicate branch from dda8def to 90c8d6b Compare February 17, 2023 09:32

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 17, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 17, 2023

bors merged commit f4f5fc3 into rust-lang:master Feb 17, 2023

rustbot added this to the 1.69.0 milestone Feb 17, 2023

bors mentioned this pull request Feb 17, 2023

Implement goal caching with the new solver #108071

Merged

rustbot removed the perf-regression Performance regression. label Feb 17, 2023

This comment has been minimized.

Sign in to view

xFrednet mentioned this pull request Feb 18, 2023

Bump rust nightly -> 2023-03-09 rust-marker/marker#101

Closed

This was referenced Mar 7, 2023

Suppress copy impl error when post-normalized type references errors #108883

Merged

ICE: min_specialization: "When translating substitutions for specialization, the expected specialization failed to hold" #108781

Closed

matthiaskrgr mentioned this pull request Aug 15, 2023

ICE: 'is_trivially_sized' applied to unexpected type #114872

Closed

matthiaskrgr mentioned this pull request Nov 18, 2023

ice: non_lifetime_binders: bound types encountered in structurally_relate_tys #118038

Open

matthiaskrgr mentioned this pull request Dec 24, 2023

ICE: predicates_of.rs: no entry found for key #119275

Closed

matthiaskrgr mentioned this pull request Jan 1, 2024

ICE: no entry found for key, expr.rs #119489

Closed

matthiaskrgr mentioned this pull request Feb 22, 2024

ICE: could not resolve DefId #121422

Closed

matthiaskrgr mentioned this pull request Mar 27, 2024

ICE: unexpected infer type #123140

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `Clause::ConstArgHasType` #107965

Add `Clause::ConstArgHasType` #107965

BoxyUwU commented Feb 12, 2023 •

edited

Loading

rustbot commented Feb 12, 2023

BoxyUwU commented Feb 12, 2023 •

edited

Loading

bors commented Feb 12, 2023

This comment has been minimized.

This comment has been minimized.

bors commented Feb 12, 2023

bors commented Feb 12, 2023

This comment has been minimized.

rust-timer commented Feb 12, 2023

This comment was marked as off-topic.

BoxyUwU commented Feb 13, 2023

compiler-errors left a comment

BoxyUwU commented Feb 16, 2023

bors commented Feb 16, 2023

BoxyUwU commented Feb 17, 2023

bors commented Feb 17, 2023

bors commented Feb 17, 2023

bors commented Feb 17, 2023

bors commented Feb 17, 2023

rust-timer commented Feb 17, 2023

This comment has been minimized.

Add Clause::ConstArgHasType #107965

Add Clause::ConstArgHasType #107965

Conversation

BoxyUwU commented Feb 12, 2023 • edited Loading

rustbot commented Feb 12, 2023

BoxyUwU commented Feb 12, 2023 • edited Loading

bors commented Feb 12, 2023

This comment has been minimized.

This comment has been minimized.

bors commented Feb 12, 2023

bors commented Feb 12, 2023

This comment has been minimized.

rust-timer commented Feb 12, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

This comment was marked as off-topic.

BoxyUwU commented Feb 13, 2023

compiler-errors left a comment

Choose a reason for hiding this comment

BoxyUwU commented Feb 16, 2023

bors commented Feb 16, 2023

BoxyUwU commented Feb 17, 2023

bors commented Feb 17, 2023

bors commented Feb 17, 2023

bors commented Feb 17, 2023

bors commented Feb 17, 2023

rust-timer commented Feb 17, 2023

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

This comment has been minimized.

Add `Clause::ConstArgHasType` #107965

Add `Clause::ConstArgHasType` #107965

BoxyUwU commented Feb 12, 2023 •

edited

Loading

BoxyUwU commented Feb 12, 2023 •

edited

Loading