resolve: Fix doc links referring to other crates when documenting proc macro crates directly #107951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @jackh726 (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
petrochenkov
commented
Feb 12, 2023
| extern crate proc_macro; | ||
| use proc_macro::*; | ||
|
|
||
| // has core/marker/trait.Unpin.html |
There was a problem hiding this comment.
I'm not sure what to write here,
// @has core/marker/trait.Unpin.html
doesn't work and reports
8: @has check failed
File does not exist 'core\\marker\\trait.Unpin.html'
// @has core/marker/trait.Unpin.html
because dependency crates like libcore are not documented in the test suite.
There was a problem hiding this comment.
You could instead add an aux crate to the test (with aux-build and build-aux-docs compiletest headers), and use a link to that instead? Or else perhaps just make it a rustdoc-ui test with #![deny(rustdoc::broken_intra_doc_links)] ?
There was a problem hiding this comment.
Ok, moved to rustdoc-ui.
…c macro crates directly
petrochenkov
force-pushed
the
procmacdoc
branch
from
a47f5e1 to
efbf654
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 19, 2023
Rollup of 7 pull requests Successful merges: - rust-lang#104659 (reflow the stack size story) - rust-lang#106933 (Update documentation of select_nth_unstable and select_nth_unstable_by to state O(n^2) complexity) - rust-lang#107783 (rustdoc: simplify DOM for `.item-table`) - rust-lang#107951 (resolve: Fix doc links referring to other crates when documenting proc macro crates directly) - rust-lang#108130 ("Basic usage" is redundant for there is just one example) - rust-lang#108146 (rustdoc: hide `reference` methods in search index) - rust-lang#108189 (Fix some more `non_lifetime_binders` stuff with higher-ranked trait bounds) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #107950