Update broken link in cargo style guide #107913
Conversation
Toml now uses [toml.io](https://toml.io) for released specifications and the github repo for development. Also the old link was for the 0.4 specification, while cargo uses toml_edit, which uses toml 1.0 (reference: https://github.com/toml-rs/toml/blob/main/crates/toml_edit/CHANGELOG.md#030---2021-09-13). Finally the discussion of "Bare keys" vs "Quoted keys" has moved from the `#table` section to `#keys`.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @compiler-errors (or someone else) soon. Please see the contribution instructions for more information. |
rustbot
added
S-waiting-on-review
|
Some changes occurred in src/doc/style-guide cc @rust-lang/style |
| @@ -17,8 +17,7 @@ followed by the `description` at the end of that section. | |||
| Don't use quotes around any standard key names; use bare keys. Only use quoted | |||
| keys for non-standard keys whose names require them, and avoid introducing such | |||
| key names when possible. See the [TOML | |||
| specification](https://github.com/toml-lang/toml/blob/master/versions/en/toml-v0.4.0.md#table) | |||
| for details. | |||
| specification](https://toml.io/en/v1.0.0#keys) for details. | |||
There was a problem hiding this comment.
Why doesn't this link to https://toml.io/en/v1.0.0 ?
There was a problem hiding this comment.
Picked a link to this heading because the old link was to a heading as well, and this heading is the most direct translation.
The link is in the style guide section about keys and answers the question "what keys are non-standard and require quoting?". Either link does the job. I'm happy to change it if you think it's better to link to the document root rather than a section.
There was a problem hiding this comment.
Oh, in that case, sure.
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#107902 (fix: improve the suggestion on future not awaited) - rust-lang#107913 (Update broken link in cargo style guide) - rust-lang#107942 (Tighter spans for bad inherent `impl` self types) - rust-lang#107948 (Allow shortcuts to directories to be used for ./x.py fmt) - rust-lang#107971 (Clearly document intentional UB in mir-opt tests) - rust-lang#107985 (Added another error to be processed in fallback) - rust-lang#108002 (Update books) - rust-lang#108013 (rustdoc: use a string with one-character codes for search index types) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Toml now uses toml.io for released specifications and the github repo for development. Also the old link was for the 0.4 specification, while cargo uses toml_edit, which uses toml 1.0 (reference:
https://github.com/toml-rs/toml/blob/main/crates/toml_edit/CHANGELOG.md#030---2021-09-13). Finally the discussion of "Bare keys" vs "Quoted keys" has moved from the
#tablesection to#keys.