Rollup of 6 pull requests #107463

Dylan-DPC · 2023-01-30T09:41:48Z

Successful merges:

Don't re-export private/unstable ArgumentV1 from alloc. #101569 (Don't re-export private/unstable ArgumentV1 from alloc.)
Pass branch.{branch}.remote=origin to git submodule update #106106 (Pass branch.{branch}.remote=origin to git submodule update)
Make unsizing_params_for_adt into a query #107146 (Make unsizing_params_for_adt into a query)
Add option to include private items in library docs #107264 (Add option to include private items in library docs)
Fix typo in {Rc, Arc}::get_mut_unchecked docs #107452 (Fix typo in {Rc, Arc}::get_mut_unchecked docs)
end entry paragraph with a period (.) #107459 (end entry paragraph with a period (.))

Failed merges:

r? @ghost
@rustbot modify labels: rollup

This works around a bug in git itself; see rust-lang#101144.

…1, r=thomcc Don't re-export private/unstable ArgumentV1 from `alloc`. The `alloc::fmt::ArgumentV1` re-export was marked as `#[stable]` even though the original `core::fmt::ArgumentV1` is `#[unstable]` (and `#[doc(hidden)]`). (It wasn't usable though: ``` error[E0658]: use of unstable library feature 'fmt_internals': internal to format_args! --> src/main.rs:4:12 | 4 | let _: alloc::fmt::ArgumentV1 = todo!(); | ^^^^^^^^^^^^^^^^^^^^^^ | = help: add `#![feature(fmt_internals)]` to the crate attributes to enable ``` ) Part of rust-lang#99012

…ark-Simulacrum Pass `branch.{branch}.remote=origin` to `git submodule update` This works around a bug in git itself. Fixes rust-lang#101144.

…=cjgillot Make `unsizing_params_for_adt` into a query Addresses a FIXME in confirmation. r? ``@ghost``

…-Simulacrum Add option to include private items in library docs I need to perform some one-off analysis on libcore, and I wanted to use the unstable JSON rustdoc output to easily do it. Unfortunately, there is currently no way to include unstable items in the library docs. This PR adds support for that, with the off-by-default `build.library-docs-private-items` setting.

…-Simulacrum Fix typo in `{Rc, Arc}::get_mut_unchecked` docs Just a correction in the documentation of `{Rc, Arc}::get_mut_unchecked`.

end entry paragraph with a period (.)

Dylan-DPC · 2023-01-30T09:41:57Z

@bors r+ rollup=never p=5

bors · 2023-01-30T09:41:59Z

📌 Commit da56c44 has been approved by Dylan-DPC

It is now in the queue for this repository.

bors · 2023-01-30T10:38:15Z

⌛ Testing commit da56c44 with merge cdff031be7b13b485212b72cb05cd696ef92f804...

bors · 2023-01-30T10:51:34Z

💔 Test failed - checks-actions

Dylan-DPC · 2023-01-30T11:09:05Z

@bors retry (spurious)

bors · 2023-01-30T11:14:24Z

⌛ Testing commit da56c44 with merge fba9f33...

rust-log-analyzer · 2023-01-30T12:14:39Z

The job i686-mingw-2 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[2524/3021] Building CXX object lib/XRay/CMakeFiles/LLVMXRay.dir/RecordInitializer.cpp.obj
[2525/3021] Building CXX object lib/ToolDrivers/llvm-lib/CMakeFiles/LLVMLibDriver.dir/LibDriver.cpp.obj
[2526/3021] Linking CXX static library lib\libLLVMDlltoolDriver.a
FAILED: lib/libLLVMDlltoolDriver.a 
cmd.exe /C "cd . && "C:\Program Files\CMake\bin\cmake.exe" -E rm -f lib\libLLVMDlltoolDriver.a && D:\a\rust\rust\mingw32\bin\ar.exe qc lib\libLLVMDlltoolDriver.a  lib/ToolDrivers/llvm-dlltool/CMakeFiles/LLVMDlltoolDriver.dir/DlltoolDriver.cpp.obj && D:\a\rust\rust\mingw32\bin\ranlib.exe lib\libLLVMDlltoolDriver.a && cd ."
D:\a\rust\rust\mingw32\bin\ar.exe: could not create temporary file whilst writing archive: no more archived files
[2527/3021] Linking CXX static library lib\libLLVMLibDriver.a
[2528/3021] Linking CXX static library lib\libLLVMDebugInfoDWARF.a
[2529/3021] Linking CXX static library lib\libLLVMObjCopy.a
[2530/3021] Linking CXX static library lib\libLLVMJITLink.a
[2530/3021] Linking CXX static library lib\libLLVMJITLink.a
[2531/3021] Linking CXX static library lib\libLLVMRuntimeDyld.a
[2532/3021] Linking CXX static library lib\libLLVMObjectYAML.a
[2533/3021] Linking CXX static library lib\libLLVMDebugInfoPDB.a
ninja: build stopped: subcommand failed.
command did not execute successfully, got: exit code: 1


build script failed, must exit now', C:\Users\runneradmin\.cargo\registry\src\github.com-1285ae84e5963aae\cmake-0.1.48\src\lib.rs:975:5
 finished in 277.711 seconds
Build completed unsuccessfully in 0:06:21
Build completed unsuccessfully in 0:06:21
make: *** [Makefile:80: ci-mingw-subset-2] Error 1

bors · 2023-01-30T13:56:33Z

☀️ Test successful - checks-actions
Approved by: Dylan-DPC
Pushing fba9f33 to master...

rust-timer · 2023-01-30T13:58:18Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#107459	804d24a6c55a631cb58114bd2157cfbe7c128d6d
#107452	010cc06c50253d087dd3a613b2900c8eaec5455b
#107264	74488de87557c0ff6e0890e871d5cd06d960d211
#107146	4cc922645f82aa5599ded3524f68f5baed82898b
#106106	80e3c1e1b9805d2ab65d8d32f7dc1a39db4ecd49
#101569	4f32d96e9a17eb3fca6fade9deb924e548dc47fa

previous master: 3f25e56496

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-01-30T16:54:43Z

Finished benchmarking commit (fba9f33): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.6%	[4.6%, 4.6%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.1%	[3.1%, 3.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.7%	[2.7%, 2.7%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

jyn514 and others added 14 commits December 23, 2022 20:10

Pass branch.{branch}.remote=origin to git submodule update

6a3ebe6

This works around a bug in git itself; see rust-lang#101144.

add option to include private items in library docs

bba274f

also document hidden items

8f84408

Make unsizing_params_for_adt into a query

32bf8c7

fix typo in {Rc, Arc}::get_mut_unchecked docs

61b18b5

Don't re-export private/unstable ArgumentV1 from alloc.

67bb7ba

Update tests.

47adb65

end entry paragraph with a period (.)

7236019

Rollup merge of rust-lang#106106 - jyn514:remote-tracking-branch, r=M…

4e5cfab

…ark-Simulacrum Pass `branch.{branch}.remote=origin` to `git submodule update` This works around a bug in git itself. Fixes rust-lang#101144.

Rollup merge of rust-lang#107146 - compiler-errors:unsizing-params, r…

e19ae97

…=cjgillot Make `unsizing_params_for_adt` into a query Addresses a FIXME in confirmation. r? ``@ghost``

Rollup merge of rust-lang#107452 - y21:get-mut-unchecked-typo, r=Mark…

f01b8f5

…-Simulacrum Fix typo in `{Rc, Arc}::get_mut_unchecked` docs Just a correction in the documentation of `{Rc, Arc}::get_mut_unchecked`.

Rollup merge of rust-lang#107459 - tshepang:cosistency, r=WaffleLapkin

da56c44

end entry paragraph with a period (.)

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 30, 2023

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 30, 2023

bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 30, 2023

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 30, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 30, 2023

bors merged commit fba9f33 into rust-lang:master Jan 30, 2023

rustbot added this to the 1.69.0 milestone Jan 30, 2023

erikdesjardins mentioned this pull request Feb 19, 2023

CI: spurious error building LLVM on mingw: ranlib.exe: could not create temporary file whilst writing archive: no more archived files #108227

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 6 pull requests #107463

Rollup of 6 pull requests #107463

Dylan-DPC commented Jan 30, 2023

Dylan-DPC commented Jan 30, 2023

bors commented Jan 30, 2023

bors commented Jan 30, 2023

bors commented Jan 30, 2023

Dylan-DPC commented Jan 30, 2023

bors commented Jan 30, 2023

rust-log-analyzer commented Jan 30, 2023

bors commented Jan 30, 2023

rust-timer commented Jan 30, 2023

rust-timer commented Jan 30, 2023

Rollup of 6 pull requests #107463

Rollup of 6 pull requests #107463

Conversation

Dylan-DPC commented Jan 30, 2023

Dylan-DPC commented Jan 30, 2023

bors commented Jan 30, 2023

bors commented Jan 30, 2023

bors commented Jan 30, 2023

Dylan-DPC commented Jan 30, 2023

bors commented Jan 30, 2023

rust-log-analyzer commented Jan 30, 2023

bors commented Jan 30, 2023

rust-timer commented Jan 30, 2023

rust-timer commented Jan 30, 2023

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles