Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make clipboard button copy crate version too instead of just crate_name #107012

Closed
wants to merge 2 commits into from
Closed

Make clipboard button copy crate version too instead of just crate_name #107012

wants to merge 2 commits into from

Conversation

atsuzaki
Copy link
Contributor

Fixes #106990

Now clipboard button will copy crate_name = "0.1.0".

r? @jyn514

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jan 17, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jan 17, 2023

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@GuillaumeGomez
Copy link
Member

Thanks for the PR! We will review it once we agree that we want this change.

@atsuzaki
Copy link
Contributor Author

@GuillaumeGomez oh I thought this issue was ready to work on. Sorry for jumping on this so soon before you guys got a chance to talk about whether you want the change or not!

@GuillaumeGomez
Copy link
Member

No problem. I think no expected to get a contributor this soon. ^^'

@jyn514
Copy link
Member

jyn514 commented Jan 17, 2023

r? @GuillaumeGomez

@rustbot rustbot assigned GuillaumeGomez and unassigned jyn514 Jan 17, 2023
@bors
Copy link
Contributor

bors commented Mar 7, 2023

☔ The latest upstream changes (presumably #108863) made this pull request unmergeable. Please resolve the merge conflicts.

@KittyBorgX
Copy link
Member

@rustbot author
@atsuzaki Hey! It looks like there are some merge conflicts in your PR. Can you sort them out?
Once you're done type in @rustbot review here so that the label can be changed to S-waiting-on-review and your PR should be good for a review!

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 29, 2023
@jyn514
Copy link
Member

jyn514 commented Apr 29, 2023

I'm going to close this for now, sorry :( I still think this is a good change but there's no point making work for you if it's not going to be accepted.

@jyn514 jyn514 closed this Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clipboard button should copy version for crate, not just the name
6 participants
@atsuzaki @rustbot @GuillaumeGomez @jyn514 @bors @KittyBorgX