Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't add A-bootstrap to PRs modifying Cargo.lock #106958

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Don't add A-bootstrap to PRs modifying Cargo.lock #106958

merged 1 commit into from
Jan 17, 2023

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Jan 17, 2023

Changing Cargo.lock is common even when adding dependencies between existing rustc crates.

cc #103204 (comment), @m-ou-se

@jyn514
Don't add A-bootstrap to PRs modifying Cargo.lock
6c76382 
Changing Cargo.lock is common even when adding dependencies between existing rustc crates.
@rustbot
Copy link
Collaborator

rustbot commented Jan 17, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 17, 2023
@jyn514 jyn514 mentioned this pull request Jan 17, 2023
Merged
@m-ou-se
Copy link
Member

m-ou-se commented Jan 17, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 17, 2023

📌 Commit 6c76382 has been approved by m-ou-se

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 17, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 17, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 17, 2023
@bors
Auto merge of rust-lang#106966 - matthiaskrgr:rollup-e34pevi, r=matth…
85357e3 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#106591 (suggestion for attempted integer identifier in patterns)
 - rust-lang#106712 (make error emitted on `impl &Trait` nicer)
 - rust-lang#106829 (Unify `Opaque`/`Projection` handling in region outlives code)
 - rust-lang#106869 (rustdoc: remove redundant item kind class from `.item-decl > pre`)
 - rust-lang#106949 (ConstBlocks are poly if their substs are poly)
 - rust-lang#106953 (Document `EarlyBinder::subst_identity` and `skip_binder`)
 - rust-lang#106958 (Don't add A-bootstrap to PRs modifying Cargo.lock)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d6e79ab into rust-lang:master Jan 17, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 17, 2023
@jyn514 jyn514 deleted the labels branch February 25, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jyn514 @rustbot @m-ou-se @bors @Mark-Simulacrum