Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move format_args!() into AST (and expand it during AST lowering) #106745

Merged
merged 20 commits into from
Jan 26, 2023
Merged

Move format_args!() into AST (and expand it during AST lowering) #106745

merged 20 commits into from
Jan 26, 2023

Commits on Jan 11, 2023

  1. Add some helper functions to LoweringContext.

    @m-ou-se
    m-ou-se committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    43105c1 View commit details
    Browse the repository at this point in the history

  2. Expose some LoweringContext methods.

    @m-ou-se
    m-ou-se committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    3c45176 View commit details
    Browse the repository at this point in the history

  3. Turn format arguments types into lang items.

    @m-ou-se
    m-ou-se committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    bebf9fe View commit details
    Browse the repository at this point in the history

  4. Add new fn to core::fmt::rt::v1::Argument.

    @m-ou-se
    m-ou-se committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    e839451 View commit details
    Browse the repository at this point in the history

  5. Expand format_args!() in rust_ast_lowering.

    @m-ou-se
    m-ou-se committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    a4dbcb5 View commit details
    Browse the repository at this point in the history

  6. Bless tests.

    @m-ou-se
    m-ou-se committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    525b0bb View commit details
    Browse the repository at this point in the history

  7. Make clippy compile.

    @m-ou-se
    m-ou-se committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    c878caf View commit details
    Browse the repository at this point in the history

  8. Update rustfmt for ast::ExprKind::FormatArgs. 

    Rustfmt doesn't expand macros, so that's easy: FormatArgs nodes do not
occur in the unexpanded AST.
    @m-ou-se
    m-ou-se committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    a1725fa View commit details
    Browse the repository at this point in the history

  9. Bless pretty tests.

    @m-ou-se
    m-ou-se committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    7a3d5fe View commit details
    Browse the repository at this point in the history

  10. Update clippy for new format_args!() lang items.

    @m-ou-se
    m-ou-se committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    36fe3b9 View commit details
    Browse the repository at this point in the history

  11. Make core::fmt::rt::v1::Argument::new const+inline.

    @m-ou-se
    m-ou-se committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    9e67854 View commit details
    Browse the repository at this point in the history

  12. Update outdated comment.

    @m-ou-se
    m-ou-se committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    bcf388f View commit details
    Browse the repository at this point in the history

  13. Update comment explaining format_args!() expansion.

    @m-ou-se
    m-ou-se committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    5659310 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2023

  1. Assume there are no macros left in ast lowering.

    @m-ou-se
    m-ou-se committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    298e160 View commit details
    Browse the repository at this point in the history

  2. Add FIXME comments about asm and format_args ast_pretty.

    @m-ou-se
    m-ou-se committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    0a1934a View commit details
    Browse the repository at this point in the history

  3. Update comments in rustc_ast_lowering/src/format.rs.

    @m-ou-se
    m-ou-se committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    8a23ad1 View commit details
    Browse the repository at this point in the history

  4. Add note on optimization in format args ast lowering.

    @m-ou-se
    m-ou-se committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    cd8ec6c View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2023

  1. Change not-so-permanent link to a more permanent link.

    @m-ou-se
    m-ou-se committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    9f2ba59 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2023

  1. Fix ast_pretty for format_args for {:x?} and {:X?}. 

    They were accidentally swapped.
    @m-ou-se
    m-ou-se committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    7b07730 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2023

  1. Work around issue 106930.

    @m-ou-se
    m-ou-se committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    db731e4 View commit details
    Browse the repository at this point in the history