Conserve cause of ImplDerivedObligation in E0599
#106702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @davidtwco (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
estebank
commented
Jan 11, 2023
estebank
force-pushed
the
trait-bounds
branch
from
6c8ca19
to
3a16c1a
Compare
compiler-errors
approved these changes
Jan 11, 2023
|
r? @compiler-errors @bors r+ as requested |
|
📌 Commit 3a16c1aa1a3fafd8103dc65f66c8b785e7ded725 has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
|
@bors r=compiler-errors |
|
📌 Commit 5e8b8e7c03a397de79afce6adcc3218b7f742409 has been approved by It is now in the queue for this repository. |
estebank
force-pushed
the
trait-bounds
branch
from
5e8b8e7
to
317adda
Compare
|
@bors r=compiler-errors |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 12, 2023
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#106167 (Fix invalid syntax and incomplete suggestion in impl Trait parameter type suggestions for E0311) - rust-lang#106309 (Prefer non-`[type error]` candidates during selection) - rust-lang#106532 (Allow codegen to unsize `dyn*` to `dyn`) - rust-lang#106596 (Hide more of long types in E0271) - rust-lang#106638 (std tests: use __OsLocalKeyInner from realstd) - rust-lang#106676 (Test that we cannot use trait impl methods arguments as defining uses) - rust-lang#106702 (Conserve cause of `ImplDerivedObligation` in E0599) - rust-lang#106732 (rustc_llvm: replace llvm::makeArrayRef with ArrayRef constructors.) - rust-lang#106733 (Revert "warn newer available version of the x tool") - rust-lang#106748 (Clean up `OnUnimplementedFormatString::verify`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
| |_idx, span| { | ||
| let misc = traits::ObligationCause::misc(span, self.body_id); | ||
| let parent_trait_pred = ty::Binder::dummy(ty::TraitPredicate { | ||
| trait_ref: ty::TraitRef::from_method(self.tcx, impl_def_id, substs), |
There was a problem hiding this comment.
I should've caught this when reviewing this, but this is not correct. We cannot construct a trait ref out of an impl def id and impl substs, and it's not meaningful to even use tcx.impl_trait_ref(impl_def_id).subst(self.tcx, substs) here because this is an inherent impl by construction.
I fixed this in #110133
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Apr 11, 2023
…trochenkov Do not use ImplDerivedObligationCause for inherent impl method error reporting We were constructing a `TraitRef` out of impl substs, for an *inherent* impl that has no corresponding trait. Instead of doing that, let's construct a meaningful obligation cause code, and instead adjust the error reporting machinery to handle that correctly. Fixes rust-lang#110131 cc rust-lang#106702, which introduced this regression
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 12, 2023
…trochenkov Do not use ImplDerivedObligationCause for inherent impl method error reporting We were constructing a `TraitRef` out of impl substs, for an *inherent* impl that has no corresponding trait. Instead of doing that, let's construct a meaningful obligation cause code, and instead adjust the error reporting machinery to handle that correctly. Fixes rust-lang#110131 cc rust-lang#106702, which introduced this regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC #86377.