Fix an insane rt build error running 'make check -j3' on Fedora #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 26, 2020
coastalwhite
pushed a commit
to coastalwhite/rust
that referenced
this pull request
Aug 5, 2023
celinval
added a commit
to celinval/rust-dev
that referenced
this pull request
Jun 4, 2024
We were restricting projections to only go through a max of one fat pointer dereference. This is not always the case, however, each projection should only care about the outer most fat pointer. Added tests to ensure this works as expected. It looks like size_of_val is returning the wrong values for the projection of traits. I'm adding fixme test cases for those here and I'll create a new issue for them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no idea how this worked before at all, or why this was occuring on my Fedora machine the way it was. Running
make checkdid not turn up this error, only runningmake check -j3did - which revealedcontext.htrying to includevalgrind/memcheck.h, while the source has its own copy.This was hidden behind a
HAS_VALGRIND, which was definitely triggered somehow - because I hadvalgrind-develinstalled on my machine, and GCC 4.6,context.hwas pulling it in and the build was failing due to the old issue #350. If I removedvalgrind-develand ran the build withmake check -j3, GCC would complain it couldn't findvalgrind/memcheck.h. Butmake checkalways works?!?!?!Either way, it's dead now.