Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct tracking issue for dyn_star #106349

Merged
merged 1 commit into from
Jan 2, 2023

Conversation

LeSeulArtichaut
Copy link
Contributor

#![feature(dyn_star)] now has its own tracking issue, #102425.

@rustbot
Copy link
Collaborator

rustbot commented Jan 1, 2023

r? @jackh726

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 1, 2023
@rust-log-analyzer

This comment has been minimized.

@jackh726
Copy link
Member

jackh726 commented Jan 1, 2023

r=me with test fixed

@bors delegete+ rollup

@jackh726
Copy link
Member

jackh726 commented Jan 1, 2023

whoops @bors delegate+

@bors
Copy link
Contributor

bors commented Jan 1, 2023

✌️ @LeSeulArtichaut can now approve this pull request

@LeSeulArtichaut LeSeulArtichaut force-pushed the dyn-star-tracking-issue branch from c35ca45 to 6289fe2 Compare January 1, 2023 18:56
@LeSeulArtichaut
Copy link
Contributor Author

@bors r=jackh726 rollup

@bors
Copy link
Contributor

bors commented Jan 1, 2023

📌 Commit 6289fe2 has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 1, 2023
@bors
Copy link
Contributor

bors commented Jan 1, 2023

⌛ Testing commit 6289fe2 with merge e11cb36...

@bors
Copy link
Contributor

bors commented Jan 2, 2023

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing e11cb36 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 2, 2023
@bors bors merged commit e11cb36 into rust-lang:master Jan 2, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 2, 2023
@LeSeulArtichaut LeSeulArtichaut deleted the dyn-star-tracking-issue branch January 2, 2023 00:42
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e11cb36): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.4% [-0.4%, -0.4%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.4% [-0.4%, -0.4%] 1

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants