Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codegen test for issue 103840 #106272

Merged
merged 1 commit into from
Jan 2, 2023
Merged

Conversation

clubby789
Copy link
Contributor

Closes #103840

@rustbot
Copy link
Collaborator

rustbot commented Dec 29, 2022

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 29, 2022
@nikic
Copy link
Contributor

nikic commented Jan 2, 2023

@bors r+ rollup=never codegen test

@bors
Copy link
Contributor

bors commented Jan 2, 2023

📌 Commit 771a2eb has been approved by nikic

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 2, 2023
@bors
Copy link
Contributor

bors commented Jan 2, 2023

⌛ Testing commit 771a2eb with merge 41de7d01ceed5927a61195375b882aa2e9c811f1...

@bors
Copy link
Contributor

bors commented Jan 2, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 2, 2023
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
.......... (90/97)
.......    (97/97)


/checkout/src/test/rustdoc-gui/code-sidebar-toggle.goml code-sidebar-toggle... FAILED
[ERROR] (line 4) Error: Execution context was destroyed, most likely because of a navigation.: for command `wait-for: "#src-sidebar-toggle"`
Build completed unsuccessfully in 0:02:36

@nikic
Copy link
Contributor

nikic commented Jan 2, 2023

@bors retry #93784

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 2, 2023
@bors
Copy link
Contributor

bors commented Jan 2, 2023

⌛ Testing commit 771a2eb with merge 23b1cc1...

@bors
Copy link
Contributor

bors commented Jan 2, 2023

☀️ Test successful - checks-actions
Approved by: nikic
Pushing 23b1cc1 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 2, 2023
@bors bors merged commit 23b1cc1 into rust-lang:master Jan 2, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 2, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (23b1cc1): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.4% [2.4%, 2.4%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-5.1% [-5.1%, -5.1%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.4% [-5.1%, 2.4%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@clubby789 clubby789 deleted the codegen-test-103840 branch February 11, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Worse codegen with mem::take(vec) than on stable
7 participants