Put non-ascii identifiers behind a feature gate. #10605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
|
||
| // a codepoint is ascii if and only if it is one byte when | ||
| // encoded as UTF-8 | ||
| if s.iter().any(|c| c.len_utf8_bytes() != 1) { |
There was a problem hiding this comment.
This could just use the is_ascii() method defined in std::ascii.
if s.is_ascii() {
...
}
|
Thanks. We'll discuss at the Tuesday meeting. |
|
Seems everyone's in favor so I'll just r+. |
bors
added a commit
that referenced
this pull request
Nov 22, 2013
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 11, 2023
Clippy Book Chapter Updates Reborn: Type Checking This PR adds a new chapter to the book: "Type Checking", it hasn't changed a lot from the source mainly because there wasn't many reviews on it and I haven't see a lot of things that needed a change. ## Notes - I have some doubts about the whole "`is_*` Usage" section, what do you think about it. - For discussion about the whole project, please use the tracking issue for the project rust-lang#10597 (It also contains a timeline, discussions, and more information) changelog: Add a new "Type Checking" chapter to the book r? `@flip1995`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf. https://mail.mozilla.org/pipermail/rust-dev/2013-November/006920.html