Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Realistic Path::as_mut_os_str doctest #105801

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Realistic Path::as_mut_os_str doctest #105801

merged 1 commit into from
Dec 20, 2022

Conversation

zertosh
Copy link
Contributor

@zertosh zertosh commented Dec 16, 2022

With "Implement DerefMut for PathBuf" (#105018) now merged, it's
possible to exercise Path::as_mut_os_str (#105002) without going
through into_boxed_path.

@rustbot
Copy link
Collaborator

rustbot commented Dec 16, 2022

r? @m-ou-se

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 16, 2022
@rustbot
Copy link
Collaborator

rustbot commented Dec 16, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@zertosh
Copy link
Contributor Author

zertosh commented Dec 19, 2022

r? @dtolnay

@rustbot rustbot assigned dtolnay and unassigned m-ou-se Dec 19, 2022
dtolnay
dtolnay approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay
Copy link
Member

dtolnay commented Dec 19, 2022

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 19, 2022

📌 Commit c68d2e4 has been approved by dtolnay

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 19, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 19, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 20, 2022
@bors
Auto merge of rust-lang#105918 - matthiaskrgr:rollup-mmazd62, r=matth…
c43bc13 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#105801 (Realistic `Path::as_mut_os_str` doctest)
 - rust-lang#105860 (Add long error docs for `E0460` and `E0457`)
 - rust-lang#105895 (Test that we don't add a new kind of breaking change with TAITs)
 - rust-lang#105902 (docs: improve pin docs)
 - rust-lang#105910 (Update books)
 - rust-lang#105913 (rustdoc: remove width-limiter from source pages, stop overriding CSS)
 - rust-lang#105915 (Revert "Replace usage of `ResumeTy` in async lowering with `Context`")

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3af45ee into rust-lang:master Dec 20, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 20, 2022
@zertosh zertosh deleted the path_mut_os_str_doc_test branch December 20, 2022 14:42
@zertosh zertosh mentioned this pull request Dec 20, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
5 participants
@zertosh @rustbot @dtolnay @bors @m-ou-se