Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move TypeckResults to separate module #105758

Merged
merged 2 commits into from
Dec 16, 2022
Merged

Conversation

Noratrieb
Copy link
Member

ty::context is really big and the typeck results aren't directly related to TyCtxt, so move them to a separate module. Also contains a small drive-by macro "improvement".

@rustbot
Copy link
Collaborator

rustbot commented Dec 15, 2022

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 15, 2022
#[macro_export]
macro_rules! parameterized_over_tcx {
($($ident:ident),+ $(,)?) => {
($($($fake_path:ident)::+),+ $(,)?) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol i thought i tried this and it didn't work

@compiler-errors
Copy link
Member

ty

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 15, 2022

📌 Commit 651e41c has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 15, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 15, 2022
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#105481 (Start improving monomorphization items stats)
 - rust-lang#105674 (Point at method chains on `E0271` errors)
 - rust-lang#105679 (Suggest constraining type parameter with `Clone`)
 - rust-lang#105694 (Don't create dummy if val has escaping bounds var)
 - rust-lang#105727 (Tweak output for bare `dyn Trait` in arguments)
 - rust-lang#105739 (Migrate Jump to def links background to CSS variable)
 - rust-lang#105743 (`SimplifiedType` cleanups)
 - rust-lang#105758 (Move `TypeckResults` to separate module)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2e03ff1 into rust-lang:master Dec 16, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 16, 2022
@Noratrieb Noratrieb deleted the typeck-results-mod branch December 23, 2022 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants