Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 11 pull requests #105746

Merged
merged 23 commits into from
Dec 15, 2022
Merged

Rollup of 11 pull requests #105746

merged 23 commits into from
Dec 15, 2022

Commits on Dec 14, 2022

  1. Add regression test for rust-lang#104678

    Signed-off-by: Yuki Okushi <jtitor@2k36.org>
    JohnTitor committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    687b4d9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5f5ae17 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bdc3c4b View commit details
    Browse the repository at this point in the history
  4. rustdoc: remove unnecessary CSS kbd { cursor: default }

    Added along with theme picker changes in
    e78f139, but no reason seems to have been
    given at the time for why this particular rule was added.
    
    Removing this rule results in `<kbd>` elements getting an I-bar, while the
    rule causes them to use the "default" arrow, but since selecting the text in
    these elements works fine, the I-bar is not misleading.
    notriddle committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    9e3d847 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7bf36de View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    cfa6a93 View commit details
    Browse the repository at this point in the history
  7. Do not mention long types in E0599 label

    The type is already mentioned in the main message and the list of unmet
    bounds.
    estebank committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    2a0d712 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    de59844 View commit details
    Browse the repository at this point in the history
  9. rustdoc: remove no-op CSS `.scrape-example .src-line-numbers { margin…

    …: 0 }`
    
    This is the default CSS for `<pre>` tags in `.code-wrapper` anyway, so this
    line does nothing.
    notriddle committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    afcc354 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2022

  1. Ensure async trait impls are async (or otherwise return an opaque type)

    As a workaround for the full `#[refine]` semantics not being implemented
    yet, forbit returning a concrete future type like `Box<dyn Future>` or a
    manually implemented Future.
    
    `-> impl Future` is still permitted; while that can also cause
    accidental refinement, that's behind a different feature gate
    (`return_position_impl_trait_in_trait`) and that problem exists
    regardless of whether the trait method is async, so will have to be
    solved more generally.
    
    Fixes rust-lang#102745
    ComputerDruid committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    da98ef9 View commit details
    Browse the repository at this point in the history
  2. rustdoc: remove no-op CSS .item-info:before { color }

    No content is set, so this pseudo-element does not exist. The CSS was
    obsoleted by 73d0f7c.
    notriddle committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    6ac0b94 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a5beb7a View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#104592 - ComputerDruid:async_check, r=compi…

    …ler-errors
    
    Ensure async trait impls are async (or otherwise return an opaque type)
    
    As a workaround for the full `#[refine]` semantics not being implemented
    yet, forbit returning a concrete future type like `Box<dyn Future>` or a
    manually implemented Future.
    
    `-> impl Future` is still permitted; while that can also cause
    accidental refinement, that's behind a different feature gate
    (`return_position_impl_trait_in_trait`) and that problem exists
    regardless of whether the trait method is async, so will have to be
    solved more generally.
    
    Fixes rust-lang#102745
    matthiaskrgr committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    c00eac3 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#105623 - compiler-errors:generator-type-siz…

    …e-fix, r=Nilstrieb
    
    Fix `-Z print-type-sizes` for generators with discriminant field ordered first
    
    Fixes rust-lang#105589
    Fixes rust-lang#105591
    matthiaskrgr committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    5d24760 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#105627 - compiler-errors:dyn-auto-suggestab…

    …le, r=davidtwco
    
    Auto traits in `dyn Trait + Auto` are suggestable
    
    Not  sure why I had made the `IsSuggestableVisitor` have that rule to not consider `dyn Trait + Auto` to be suggestable.
    
    It's possible that this was done because of the fact that we don't print the right parentheses for `&(dyn Trait + Auto)`, but that's a problem with printing these types in general that we probably have tracked somewhere else...
    matthiaskrgr committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    a2c9f2a View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#105633 - compiler-errors:term-agnostic, r=o…

    …li-obk
    
    Make `report_projection_error` more `Term` agnostic
    
    Fixes rust-lang#105632
    matthiaskrgr committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    78cf8cc View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#105683 - JakobDegen:dest-prop-storage, r=tm…

    …iasko
    
    Various cleanups to dest prop
    
    This makes fixing the issues identified in rust-lang#105577 easier. A couple changes
    
     - Use an enum with names instead of a bool
     - Only call `remove_candidates_if` from one place instead of two. Doing it from two places is far too fragile, since any divergence in the behavior between those callsites is likely to be unsound.
     - Remove `is_constant`. Right now we only merge locals, so this doesn't do anything, and the logic would be wrong if it did.
    
    r? `@tmiasko`
    matthiaskrgr committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    6cdc83b View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#105692 - JohnTitor:issue-104678, r=compiler…

    …-errors
    
    Add regression test for rust-lang#104678
    
    Closes rust-lang#104678
    r? `````@compiler-errors`````
    
    Signed-off-by: Yuki Okushi <jtitor@2k36.org>
    matthiaskrgr committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    8111cc4 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#105707 - notriddle:notriddle/kbd-cursor, r=…

    …jhpratt,GuillaumeGomez
    
    rustdoc: remove unnecessary CSS `kbd { cursor: default }`
    
    Added along with theme picker changes in https://github.com/rust-lang/rust/pull/47686/files#diff-7dc22a0530802d77c2f2ec9e834024a5657b6eab4055520fca46edc99a544413R1144, but no reason seems to have been given at the time for why this particular rule was added.
    
    Removing this rule results in `<kbd>` elements getting an I-bar, while the rule causes them to use the "default" arrow, but since selecting the text in these elements works fine, the I-bar is not misleading.
    matthiaskrgr committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    a6337d3 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#105715 - estebank:unsatisfied-bounds-label,…

    … r=compiler-errors
    
    Do not mention long types in E0599 label
    
    The type is already mentioned in the main message and the list of unmet bounds.
    matthiaskrgr committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    cb9bcaf View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#105722 - matthiaskrgr:compl2, r=compiler-er…

    …rors
    
    more clippy::complexity fixes
    
    r? ```@compiler-errors```
    matthiaskrgr committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    c0862f3 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#105724 - notriddle:notriddle/scrape-example…

    …-src-line-numbers, r=GuillaumeGomez
    
    rustdoc: remove no-op CSS `.scrape-example .src-line-numbers { margin: 0 }`
    
    This is the default CSS for `<pre>` tags in `.code-wrapper` anyway, so this line does nothing.
    matthiaskrgr committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    99a1bfc View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#105730 - notriddle:notriddle/item-info-befo…

    …re, r=GuillaumeGomez
    
    rustdoc: remove no-op CSS `.item-info:before { color }`
    
    No content is set, so this pseudo-element does not exist. The CSS was obsoleted by 73d0f7c.
    matthiaskrgr committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    2650b7b View commit details
    Browse the repository at this point in the history