Make BytePos 32-bit #10567
Make BytePos 32-bit #10567
Conversation
|
Out of curiosity, was this done to reduce memory usage? If so, do you have numbers for before/after? |
|
I get 1410 MiB before and 1397 MiB after for librustc compile, so 13 MiB less on x86-64 Linux. Not a lot, but the patch is tiny. |
|
@sanxiyn Can you add a comment explaining why u32 is picked there to prevent anybody from changing it back? |
|
What if the file is larger than 4GB (e.g. it contains lots of static data), which can happen on 32-bit platforms too? Shouldn't it be u64 instead? |
|
@brson A comment added. @bill-myers I don't think anyone will compile 4 GiB compilation unit soon. |
|
And, if one is trying to compile a 4+GB file, the resulting internal compiler datastructures will certainly be much larger than 4GB, i.e. not possible on 32-bit anyway. (E.g. there's 3MB of Rust source in librustc, which becomes 1400MB during compilation.) |
…derscore, r=dswij Emit `unnecessary_cast` on raw pointers as well Supersedes(?) rust-lang#10782, since this and rust-lang#10567 will cover the original issue. Does not lint on type aliases or inferred types. changelog: [`unnecessary_cast`]: Also emit on casts between raw pointers with the same type and constness
No description provided.