Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest impl in the scenario of typo with fn #105502

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Suggest impl in the scenario of typo with fn #105502

merged 1 commit into from
Dec 14, 2022

Conversation

chenyukang
Copy link
Member

Fixes #105366

@rustbot
Copy link
Collaborator

rustbot commented Dec 9, 2022

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 9, 2022
@chenyukang chenyukang marked this pull request as draft December 9, 2022 17:40
@chenyukang chenyukang force-pushed the yukang/fix-105366-impl branch from b2014f1 to b70a869 Compare December 10, 2022 03:02
@rustbot rustbot added the A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic label Dec 10, 2022
@chenyukang chenyukang marked this pull request as ready for review December 10, 2022 03:02
@rustbot
Copy link
Collaborator

rustbot commented Dec 10, 2022

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

@chenyukang chenyukang changed the title [WIP] Suggest impl in the scenario of typo with fn Suggest impl in the scenario of typo with fn Dec 10, 2022
@estebank
Copy link
Contributor

r? @estebank
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 13, 2022

📌 Commit b70a869 has been approved by estebank

It is now in the queue for this repository.

@rustbot rustbot assigned estebank and unassigned wesleywiser Dec 13, 2022
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 13, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 14, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 14, 2022
@bors
Auto merge of rust-lang#105686 - matthiaskrgr:rollup-bedfk3j, r=matth…
7bdda8f 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#103644 (Add docs for question mark operator for Option)
 - rust-lang#105161 (Refine when invalid prefix case error arises)
 - rust-lang#105491 (Illegal sized bounds: only suggest mutability change if needed)
 - rust-lang#105502 (Suggest impl in the scenario of typo with fn)
 - rust-lang#105523 (Suggest `collect`ing into `Vec<_>`)
 - rust-lang#105595 (Suggest dereferencing receiver arguments properly)
 - rust-lang#105611 (fold instead of obliterating args)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c8fd654 into rust-lang:master Dec 14, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.

improve suggestion when writing "fn Trait for Ty" instead of "impl Trait for Ty"
5 participants
@chenyukang @rustbot @estebank @bors @wesleywiser