Check AArch64 branch-protection earlier in the pipeline.

[jacobbramley]

As suggested in #93516.

r? @nagisa

[rustbot]

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

[nagisa]

Really nice. One nit inline, but otherwise r=me.

[nagisa]

Rather than making this a no-op, we should probably bug! this, so that any issues with checking in rustc_session don’t get silently ignored.

[jacobbramley]

Good point! Done in 73d374f.

[nagisa]

@bors r+

[bors]

📌 Commit 73d374f has been approved by nagisa

It is now in the queue for this repository.

[bors]

⌛ Testing commit 73d374f with merge e2bf6962bd0d2bd9a3710dc9fb074eb049d2d957...

[bors]

💔 Test failed - checks-actions

[jacobbramley]

💔 Test failed - checks-actions

The test fails on an off-by-one error on some documentation layout. It doesn't appear at all relevant to this PR. Note, however, that I can reproduce the error reliably on my branch, but only when run as part of the full sequence. For example, I can't reproduce it by isolating the failing test as follows:

x test --stage 2 src/test/rustdoc-gui --test-args '--no-sandbox --jobs 1 --file scrape-examples-button-focus.goml'

Note that dropping --jobs 1 gets me different results, with intermittent failures on varying tests. However, the tests don't run that way in CI so that usage might not be expected to work anyway.

Attempting to work out what the failure actually was:

[Expected 248 for property scrollTop, found 249]

Manually rendering the test file in Firefox shows a scrollTop of 249 (before and after the navigation operation), so I suspect that the initialScrollTop seen in the test is the anomaly (or perhaps this is just browser variation).

At this point, I am somewhat at a loss. @willcrichton, it seems that you did some work on this test recently. Have you any ideas?

[rust-log-analyzer]

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

.......... (90/93)
...        (93/93)


/checkout/src/test/rustdoc-gui/scrape-examples-button-focus.goml scrape-examples-button-focus... FAILED
[ERROR] (line 12) Error: Evaluation failed: The following errors happened (for selector `.scraped-example-list > .scraped-example pre`): [Expected `248` for property `scrollTop`, found `249`]: for command `assert-property: (".scraped-example-list > .scraped-example pre", {
 "scrollTop": |initialScrollTop|

Build completed unsuccessfully in 0:02:28

[tmiasko]

@bors retry unrelated rustdoc-gui failure

[willcrichton]

I will check why this test is flaky. cc @GuillaumeGomez have you seen any issues like this w/ browser-UI-test before?

[bors]

⌛ Testing commit 73d374f with merge 6ea11f0a9cc8b2b2792e1d101bddad3b4978b7b2...

[bors]

💔 Test failed - checks-actions

[willcrichton]

Oh no, a different GUI test failed... @GuillaumeGomez this looks like a broader flakiness problem.

[GuillaumeGomez]

For the GUI failure, linked to #93784.

[GuillaumeGomez]

Since it's not related to this PR, let's retry.

@bors retry

[bors]

⌛ Testing commit 73d374f with merge aef17b7...

[bors]

☀️ Test successful - checks-actions
Approved by: nagisa
Pushing aef17b7 to master...

[rust-timer]

Finished benchmarking commit (aef17b7): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.4%	[-0.4%, -0.4%]	1
Improvements ✅ (secondary)	-0.4%	[-0.4%, -0.4%]	1
All ❌✅ (primary)	-0.4%	[-0.4%, -0.4%]	1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.1%	[3.1%, 3.1%]	1
Regressions ❌ (secondary)	3.5%	[3.5%, 3.5%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.1%	[3.1%, 3.1%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

[rust-log-analyzer]

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

.......... (90/93)
...        (93/93)


/checkout/src/test/rustdoc-gui/basic-code.goml basic-code... FAILED
[ERROR] (line 3) Error: Execution context was destroyed, most likely because of a navigation.: for command `assert-count: (".src-line-numbers", 1)`
Build completed unsuccessfully in 0:02:31