Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make VecDeque::new_in unstably const #105126

Merged
merged 2 commits into from
Dec 2, 2022
Merged

Make VecDeque::new_in unstably const #105126

merged 2 commits into from
Dec 2, 2022

Conversation

Sp00ph
Copy link
Member

@Sp00ph Sp00ph commented Dec 1, 2022

(See #105072)

@rustbot
Copy link
Collaborator

rustbot commented Dec 1, 2022

r? @thomcc

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 1, 2022
@rustbot
Copy link
Collaborator

rustbot commented Dec 1, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@Sp00ph
Copy link
Member Author

Sp00ph commented Dec 1, 2022

@rustbot label +T-libs-api -T-libs

@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 1, 2022
@dtolnay dtolnay assigned dtolnay and unassigned thomcc Dec 1, 2022
dtolnay
dtolnay approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay
Copy link
Member

dtolnay commented Dec 1, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Dec 1, 2022

📌 Commit c959fbe has been approved by dtolnay

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 1, 2022
@dtolnay dtolnay mentioned this pull request Dec 1, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 2, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 2, 2022
@bors
Auto merge of rust-lang#105166 - matthiaskrgr:rollup-s9l6vt2, r=matth…
cef44f5 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#104614 (Add `type_ascribe!` macro as placeholder syntax for type ascription)
 - rust-lang#105126 (Make `VecDeque::new_in` unstably const)
 - rust-lang#105132 (Migrate summary toggle filter to CSS variable)
 - rust-lang#105136 (clarify comment on Deref promotion)
 - rust-lang#105137 (Add tracking issue number for `file_create_new` feature)
 - rust-lang#105143 (rustdoc: use simpler CSS for setting the font on scraped examples)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4c4dec4 into rust-lang:master Dec 2, 2022
@rustbot rustbot added this to the 1.67.0 milestone Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Sp00ph @rustbot @dtolnay @bors @thomcc