Add sentence when rustdoc search is running #105016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
added
A-rustdoc-ui
rustbot
added
S-waiting-on-review
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
|
Ah hold on, I introduced a bug by doing so: the crate search filter isn't working anymore with this change. I need to fix it first and add a GUI test for it. |
notriddle
reviewed
Nov 28, 2022
GuillaumeGomez
force-pushed
the
load-sentence-rustdoc
branch
from
08b6148 to
7d86190
Compare
GuillaumeGomez
force-pushed
the
load-sentence-rustdoc
branch
from
7d86190 to
20f389d
Compare
|
There was already code existing doing the same thing when arriving on a page with a search URL parameter. So instead I put this code into a |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 28, 2022
…oc, r=notriddle Add sentence when rustdoc search is running This is a small improvement, mostly relevant on big search indexes. As soon as the search starts, it'll display:  cc `@jsha` r? `@notriddle`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 29, 2022
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#104465 (Document more settings for building rustc for Fuchsia) - rust-lang#104951 (Simplify checking for `GeneratorKind::Async`) - rust-lang#104959 (Revert rust-lang#104269 (to avoid spurious hang/test failure in CI)) - rust-lang#104978 (notify the rust-analyzer team on changes to the rust-analyzer subtree) - rust-lang#105010 (Fix documentation of asymptotic complexity for rustc_data_structures::SortedMap) - rust-lang#105016 (Add sentence when rustdoc search is running) - rust-lang#105020 (rustdoc: merge background-image rules in rustdoc-toggle CSS) - rust-lang#105024 (rustdoc: remove `fnname` CSS class that's styled exactly like `fn`) - rust-lang#105027 (Rustdoc-Json: Add tests for linking to foreign variants.) - rust-lang#105038 (Clean up pr 104954) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small improvement, mostly relevant on big search indexes. As soon as the search starts, it'll display:
cc @jsha
r? @notriddle