Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass clippy sysroot env if given #104619

Closed
wants to merge 1 commit into from
Closed

pass clippy sysroot env if given #104619

wants to merge 1 commit into from

Conversation

onur-ozkan
Copy link
Member

@onur-ozkan onur-ozkan commented Nov 19, 2022 •
edited
Loading

@onur-ozkan
pass clippy sysroot env if given r=ozkanonur
0282bc2 
Signed-off-by: ozkanonur <work@onurozkan.dev>
@rustbot
Copy link
Collaborator

rustbot commented Nov 19, 2022

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 19, 2022
@rustbot
Copy link
Collaborator

rustbot commented Nov 19, 2022

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@Mark-Simulacrum
Copy link
Member

r? @jyn514

@rustbot rustbot assigned jyn514 and unassigned Mark-Simulacrum Nov 20, 2022
@flip1995
Copy link
Member

Thanks! Please don't merge this in this repo. I will cherry pick this commit over to rust-lang/rust-clippy#9881 and then sync it to here. That way this will get tested in Clippy CI and we know that we're back in a backwards compatible state.

@matthiaskrgr matthiaskrgr added S-blocked Status: Blocked on something else such as an RFC or other implementation work. A-clippy Area: Clippy labels Nov 21, 2022
@flip1995
Copy link
Member

Cherry-picked and merged in rust-lang/rust-clippy#9881 into the Clippy repo and synced in #104688 with commit 5907e91, so can be closed now. Thanks again for addressing this so quickly!

@flip1995 flip1995 closed this Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jyn514 jyn514

Labels
A-clippy Area: Clippy S-blocked Status: Blocked on something else such as an RFC or other implementation work. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@onur-ozkan @rustbot @Mark-Simulacrum @flip1995 @matthiaskrgr @jyn514