Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resolution_failure ICE #104052

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Fix resolution_failure ICE #104052

merged 1 commit into from
Nov 7, 2022

Conversation

TaKO8Ki
Copy link
Member

@TaKO8Ki TaKO8Ki commented Nov 6, 2022

Fixes #103997

@rustbot
Copy link
Collaborator

rustbot commented Nov 6, 2022

r? @notriddle

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Nov 6, 2022
@petrochenkov
Copy link
Contributor

I think this PRs only hides the underlying issue, the erroneous Self shouldn't resolve to Res::Def(DefKind::Use, _) in the first place.

@TaKO8Ki
Copy link
Member Author

TaKO8Ki commented Nov 6, 2022

Or should rustdoc warn like the following? @rust-lang/rustdoc If so, I think we need to improve LinkCollector::resolve_self_ty.

warning: unresolved link to `Self::foo`
 --> src/main.rs:3:13
  |
3 | /// [`foo`](Self::foo)
  |             ^^^^^^^^^ no item named `Self` in scope
  |
  = note: `#[warn(rustdoc::broken_intra_doc_links)]` on by default

warning: `debug_playground` (bin "debug_playground" doc) generated 1 warning

@GuillaumeGomez
Copy link
Member

Would be better indeed.

@notriddle
Copy link
Contributor

Squash these into a single commit, then r=me

@TaKO8Ki
Copy link
Member Author

TaKO8Ki commented Nov 7, 2022

@bors r=notriddle

@bors
Copy link
Contributor

bors commented Nov 7, 2022

📌 Commit 6b2257b has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Nov 7, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 7, 2022
@bors
Auto merge of rust-lang#104102 - Dylan-DPC:rollup-0eakshe, r=Dylan-DPC
68f7729 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#103757 (Mention const and lifetime parameters in error E0207)
 - rust-lang#103986 (Don't silently eat label before block in block-like expr)
 - rust-lang#104003 (Move some tests to more reasonable directories)
 - rust-lang#104038 (Normalize types when deducing closure signature from supertraits)
 - rust-lang#104052 (Fix `resolution_failure` ICE)
 - rust-lang#104090 (Modify comment syntax error)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 498efa6 into rust-lang:master Nov 7, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@notriddle notriddle

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.

Typo in docs causes ICE
6 participants
@TaKO8Ki @rustbot @petrochenkov @GuillaumeGomez @notriddle @bors