rustdoc: use ThinVec and Box<str> to shrink clean::ItemKind

[notriddle]

No description provided.

[rustbot]

r? @CraftSpider

(rustbot has picked a reviewer for you, use r? to override)

[notriddle]

@bors try @rust-timer queue

[bors]

⌛ Trying commit a69d434 with merge 1851fcbca778b400a04c1906feac58addf20d15e...

[bors]

☀️ Try build successful - checks-actions
Build commit: 1851fcbca778b400a04c1906feac58addf20d15e (1851fcbca778b400a04c1906feac58addf20d15e)

[rust-timer]

Finished benchmarking commit (1851fcbca778b400a04c1906feac58addf20d15e): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.2%, 0.4%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.3%	[0.2%, 0.4%]	3

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.5%, 0.9%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.4%	[-2.6%, -0.4%]	6
Improvements ✅ (secondary)	-1.9%	[-2.5%, -1.7%]	4
All ❌✅ (primary)	-0.7%	[-2.6%, 0.9%]	9

Cycles

This benchmark run did not return any relevant results for this metric.

[notriddle]

@bors try @rust-timer queue

[bors]

⌛ Trying commit e410cd2 with merge 38369380a37c424f80f24ce33028186d02dd5f2c...

[bors]

☀️ Try build successful - checks-actions
Build commit: 38369380a37c424f80f24ce33028186d02dd5f2c (38369380a37c424f80f24ce33028186d02dd5f2c)

[rust-timer]

Finished benchmarking commit (38369380a37c424f80f24ce33028186d02dd5f2c): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.2%	[0.4%, 3.0%]	4
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.3%	[-2.3%, -0.4%]	19
Improvements ✅ (secondary)	-2.4%	[-3.0%, -2.0%]	3
All ❌✅ (primary)	-0.9%	[-2.3%, 3.0%]	23

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.8%	[2.8%, 4.8%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

[rustbot]

Some changes occurred in src/librustdoc/clean/types.rs

cc @camelid

[GuillaumeGomez]

I'm surprised reducing these items' size didn't impact perf. If there is nothing else to be done, r=me since it's still a gain and the code doesn't get bigger/more complicated either.

[notriddle]

@bors r=GuillaumeGomez

I don’t have anything new planned right now.

[bors]

📌 Commit e410cd2 has been approved by GuillaumeGomez

It is now in the queue for this repository.

[bors]

⌛ Testing commit e410cd2 with merge 29c06956da955744921922e2661f96d729072b1f...

[bors]

💥 Test timed out

[notriddle]

@bors retry

[rust-log-analyzer]

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[bors]

⌛ Testing commit e410cd2 with merge 6184a96...

[bors]

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 6184a96 to master...

[rust-timer]

Finished benchmarking commit (6184a96): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.4%	[0.4%, 0.5%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.5%	[-1.6%, -1.3%]	6
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.8%	[0.5%, 3.4%]	3
Regressions ❌ (secondary)	1.9%	[1.1%, 3.4%]	3
Improvements ✅ (primary)	-2.3%	[-2.7%, -1.9%]	2
Improvements ✅ (secondary)	-1.8%	[-2.5%, -1.5%]	3
All ❌✅ (primary)	0.2%	[-2.7%, 3.4%]	5

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	6.1%	[6.1%, 6.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0