Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linker-plugin-lto.md to contain up to Rust 1.65 #103955

Merged
merged 2 commits into from
Nov 8, 2022

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Nov 4, 2022

The table rows were obtained via the script embedded in the page.

The table rows were obtained via the script embedded in the page.
@rustbot
Copy link
Collaborator

rustbot commented Nov 4, 2022

r? @ehuss

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 4, 2022
@str4d
Copy link
Contributor Author

str4d commented Nov 4, 2022

This table is starting to get a bit unwieldy, though there are much larger tables elsewhere in the book, so maybe it's fine. For now I've kept updating it per the script embedded in the page, but we could alternatively switch to a range-based table, if that fits with how Rust does LLVM updates:

Rust Version Clang Version
Rust 1.34 - 1.37 Clang 8
Rust 1.38 - 1.44 Clang 9
Rust 1.45 - 1.46 Clang 10
Rust 1.47 - 1.51 Clang 11
Rust 1.52 - 1.55 Clang 12
Rust 1.56 - 1.59 Clang 13
Rust 1.60 - 1.64 Clang 14
Rust 1.65 Clang 15

@ehuss
Copy link
Contributor

ehuss commented Nov 5, 2022

The range-based table definitely looks a lot nicer. I imagine it might make it a little more awkward if someone just wants to search for a specific version, but I don't think that should be too much of a concern. If you want, would you mind switching it to that?

The helper shell script has been rewritten as a helper Python script
that generates the range-based table.
@str4d
Copy link
Contributor Author

str4d commented Nov 7, 2022

Done. I also updated the script to generate the range-based table (but without the "Rust" and "Clang" prefixes on each row, as they duplicate the column headers).

@ehuss
Copy link
Contributor

ehuss commented Nov 7, 2022

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 7, 2022

📌 Commit ee7a802 has been approved by ehuss

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2022
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 7, 2022
Update linker-plugin-lto.md to contain up to Rust 1.65

The table rows were obtained via the script embedded in the page.
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 7, 2022
Update linker-plugin-lto.md to contain up to Rust 1.65

The table rows were obtained via the script embedded in the page.
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 8, 2022
Rollup of 7 pull requests

Successful merges:

 - rust-lang#103446 (Specialize `iter::ArrayChunks::fold` for TrustedRandomAccess iterators)
 - rust-lang#103651 (Fix `rustc_parse_format` spans following escaped utf-8 multibyte chars)
 - rust-lang#103865 (Move `fallback_has_occurred` state tracking to `FnCtxt`)
 - rust-lang#103955 (Update linker-plugin-lto.md to contain up to Rust 1.65)
 - rust-lang#103987 (Remove `in_tail_expr` from FnCtxt)
 - rust-lang#104067 (fix debuginfo for windows_gnullvm_base.rs)
 - rust-lang#104094 (fully move `on_unimplemented` to `error_reporting`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 799648a into rust-lang:master Nov 8, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 8, 2022
@str4d str4d deleted the update-lto-doc-1.65 branch November 8, 2022 22:30
@str4d str4d restored the update-lto-doc-1.65 branch January 11, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants