Rollup of 10 pull requests #103954
Merged
Rollup of 10 pull requests #103954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exact same background is already set for its parent, the `nav.sidebar`.
Hardcoded colors in rustdoc.css should usually be avoided.
When this line was added in 04b4c40, it overrode a negative `margin-top` that was set on it by default. https://github.com/rust-lang/rust/blob/04b4c40682c01cad8f9bc8d5b3907be91d6f81d4/src/librustdoc/html/static/rustdoc.css#L500-L516 That negative top margin was removed in 593d6d1.
…etroalbini Remove let_underscore_must_use from list of uplifted lints Per https://internals.rust-lang.org/t/rust-1-65-0-pre-release-testing/17660/2 We probably won't backport this (not worth rebuilding stable artifacts over it) but still should be fixed.
…sit, r=compiler-errors Add visit_fn_ret_ty to hir intravisit I'm working on some RPITIT changes and I need to specialize `visit_fn_ret_ty` in my visitor impl. So I guess it's better to land it separately. r? `@compiler-errors`
…illaumeGomez Properly render asyncness for trait fns without default body We weren't properly desugaring async fns in traits unless they had default bodies (in which case rustdoc treats them much like they came from an impl). cc ```@yoshuawuyts``` should help with https://rust-lang.zulipchat.com/#narrow/stream/330606-wg-async.2Fasync-fn-in-trait-impl/topic/type.20inside.20.60async.20fn.60.20body.20must.20be.20known.20in.20this.20context/near/306894869
…background, r=GuillaumeGomez
rustdoc: remove redundant mobile CSS `.sidebar-elems { background }`
The exact same background is already set for its parent, the `nav.sidebar`.
…=davidtwco Add howto for adding new targets When new targets are added, often a reviewer finds out that e.g. the target-3-tier-policy is not filled out (missing), there is no description etc. This change adds a description of what I've learned while working on rust-lang#102701. It should make reviews easier in the future with less rework. r? compiler-team
Improve use of ErrorGuaranteed and code cleanup Part of rust-lang#103874
…jyn514 Move some tests from `src/test/ui` to more reasonable places
…-atop-lld, r=Mark-Simulacrum Add note to RELEASES.md regarding issue 102754. As discussed in [compiler triage meeting today](https://rust-lang.zulipchat.com/#narrow/stream/238009-t-compiler.2Fmeetings/topic/.5Bweekly.5D.202022-11-03/near/307746618); it would have been nice to get this in time for the stable notes, but having it only in nightly only is better than nothing... r? `@Mark-Simulacrum`
…-border-bottom, r=GuillaumeGomez rustdoc: clean up hardcoded CSS border color on search results Hardcoded colors in rustdoc.css should usually be avoided. Preview: http://notriddle.com/notriddle-rustdoc-demos/border-bottom-search/test_dingus/?search=test
…tem-info-margin-top, r=GuillaumeGomez
rustdoc: remove no-op CSS `#main-content > .item-info { margin-top: 0 }`
When this line was added in 04b4c40, it overrode a negative `margin-top` that was set on it by default.
https://github.com/rust-lang/rust/blob/04b4c40682c01cad8f9bc8d5b3907be91d6f81d4/src/librustdoc/html/static/rustdoc.css#L500-L516
That negative top margin was removed in 593d6d1.
rustbot
added
A-testsuite
|
@bors r+ rollup=never p=10 |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 923d907 with merge fbb410ef21c0570d00cbcb55591ffae69252c4d0... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry curl: (35) OpenSSL SSL_connect: Connection reset by peer in connection to ci-mirrors.rust-lang.org:443 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: previous master: 15d7556de9 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Nov 4, 2022
Merged
|
Finished benchmarking commit (2efb0cd): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
.sidebar-elems { background }#103905 (rustdoc: remove redundant mobile CSS.sidebar-elems { background })src/test/uito more reasonable places #103930 (Move some tests fromsrc/test/uito more reasonable places)#main-content > .item-info { margin-top: 0 }#103940 (rustdoc: remove no-op CSS#main-content > .item-info { margin-top: 0 })Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup