-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix capacity overflow issue during transmutability check #103831
Conversation
r? @nagisa (rustbot has picked a reviewer for you, use r? to override) |
de49e26
to
749afe5
Compare
@@ -0,0 +1,29 @@ | |||
#![crate_type = "lib"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW it is useful to name regression tests after the issues they come from. This has couple purposes:
- It is easy to see this is a regression test;
- Resolving to the original issue report takes a single dereference (rather than having to go through
git log
, looking at the commit message and only then finding the issue number to load up.)
Not a huge deal either way though.
@bors r+ thanks! |
☀️ Test successful - checks-actions |
Finished benchmarking commit (6b8d9dd): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
…nagisa Fix capacity overflow issue during transmutability check Fixes rust-lang#103751
Fixes #103751