Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace libstd, libcore, liballoc terminology in docs #103707

Merged
merged 3 commits into from
Dec 30, 2022
Merged

Replace libstd, libcore, liballoc terminology in docs #103707

merged 3 commits into from
Dec 30, 2022

Conversation

jonathanCogan
Copy link
Contributor

Fixes #103551. I changed line comments containing the outdated terms as well.

It would be great if someone with more experience could weigh in on whether these changes introduce ambiguity as suggested in #103551 (comment).

@rustbot
Copy link
Collaborator

rustbot commented Oct 29, 2022

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @m-ou-se (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 29, 2022
@rustbot
Copy link
Collaborator

rustbot commented Oct 29, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

ghost
ghost suggested changes Nov 3, 2022
View reviewed changes
library/alloc/src/slice.rs Outdated Show resolved Hide resolved
library/core/tests/str.rs Outdated Show resolved Hide resolved
library/core/src/lib.rs Outdated Show resolved Hide resolved
@inquisitivecrystal inquisitivecrystal added the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Nov 4, 2022
@jonathanCogan
Copy link
Contributor Author

@bors r=H4x5

@bors
Copy link
Contributor

bors commented Nov 4, 2022

@jonathanCogan: 🔑 Insufficient privileges: Not in reviewers

@bors
Copy link
Contributor

bors commented Dec 2, 2022

☔ The latest upstream changes (presumably #104999) made this pull request unmergeable. Please resolve the merge conflicts.

@m-ou-se
Copy link
Member

m-ou-se commented Dec 30, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Dec 30, 2022

📌 Commit e2166188100f3a84ab49003193b5034fcc469fbb has been approved by m-ou-se

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 30, 2022
@m-ou-se
Copy link
Member

m-ou-se commented Dec 30, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Dec 30, 2022

📌 Commit 78691e3 has been approved by m-ou-se

It is now in the queue for this repository.

@matthiaskrgr matthiaskrgr mentioned this pull request Dec 30, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 30, 2022
@bors
Auto merge of rust-lang#106296 - matthiaskrgr:rollup-ukdbqwx, r=matth…
bbdca4c 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#99244 (doc: clearer and more correct Iterator::scan)
 - rust-lang#103707 (Replace libstd, libcore, liballoc terminology in docs)
 - rust-lang#104182 (`IN6ADDR_ANY_INIT` and `IN6ADDR_LOOPBACK_INIT` documentation.)
 - rust-lang#106273 (rustdoc: remove redundant CSS `.source .content { overflow: visible }`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 25b1f1c into rust-lang:master Dec 30, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees

@m-ou-se m-ou-se

Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.

Replace libstd, libcore, liballoc terminology in docs
5 participants
@jonathanCogan @rustbot @bors @m-ou-se @inquisitivecrystal