Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: remove redundant CSS selector .notable-traits .notable #103592

Merged
merged 2 commits into from
Oct 27, 2022
Merged

rustdoc: remove redundant CSS selector .notable-traits .notable #103592

merged 2 commits into from
Oct 27, 2022

Conversation

notriddle
Copy link
Contributor

The margin was already being set to 0 only a few lines lower.

@notriddle
rustdoc: remove redundant CSS selector .notable-traits .notable
3dd7009 
The margin was already being set to 0 only a few lines lower.
@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Oct 26, 2022
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jsha (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot
Copy link
Collaborator

rustbot commented Oct 26, 2022

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 26, 2022
@GuillaumeGomez
Copy link
Member

Can you add a GUI test to ensure that please?

@notriddle
Copy link
Contributor Author

You want a GUI test that ensures .notable-traits .notable has a margin of 0?

@GuillaumeGomez
Copy link
Member

More like a general one: we currently only test the position of the "i" but we don't check the content of the popup.

@notriddle
Copy link
Contributor Author

@GuillaumeGomez Okay, added test code for the positioning of the tooltip popup.

@GuillaumeGomez
Copy link
Member

Sorry, I should have been more explicit: I only had in mind the margin since it was what you updated. Your add is very much appreciated, thanks a lot for doing it! r=me once CI pass

@notriddle
Copy link
Contributor Author

@bors r=GuillaumeGomez

@bors
Copy link
Contributor

bors commented Oct 26, 2022

📌 Commit a7a0b36 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 27, 2022
@matthiaskrgr
Rollup merge of rust-lang#103592 - notriddle:notriddle/notable-traits…
30fc2a4 
…-notable, r=GuillaumeGomez

rustdoc: remove redundant CSS selector `.notable-traits .notable`

The margin was already being set to 0 only a few lines lower.
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 27, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 27, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 27, 2022
@bors
Auto merge of rust-lang#103623 - matthiaskrgr:rollup-318yc1t, r=matth…
0da281b 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#103035 (Even nicer errors from assert_unsafe_precondition)
 - rust-lang#103106 (Try to say that memory outside the AM is always exposed)
 - rust-lang#103475 (Make param index generation a bit more robust)
 - rust-lang#103525 (Move a wf-check into the site where the value is instantiated)
 - rust-lang#103564 (library: allow some unused things in Miri)
 - rust-lang#103586 (Process registered region obligation in `resolve_regions_with_wf_tys`)
 - rust-lang#103592 (rustdoc: remove redundant CSS selector `.notable-traits .notable`)
 - rust-lang#103593 (Remove an unused parser function (`Expr::returns`))
 - rust-lang#103611 (Add test for issue 103574)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 29698dc into rust-lang:master Oct 27, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 27, 2022
@notriddle notriddle deleted the notriddle/notable-traits-notable branch October 27, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@jsha jsha

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.
6 participants
@notriddle @rust-highfive @rustbot @GuillaumeGomez @bors @jsha