-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggest calling the instance method of the same name when method not found #103531
Conversation
r? @estebank (rust-highfive has picked a reviewer for you, use r? to override) |
acdef1d
to
6287ac7
Compare
6287ac7
to
32a2f0d
Compare
@@ -381,11 +381,13 @@ impl<'a: 'ast, 'ast> LateResolutionVisitor<'a, '_, 'ast> { | |||
} | |||
|
|||
fn suggest_self_or_self_ref(&mut self, err: &mut Diagnostic, path: &[Segment], span: Span) { | |||
let is_assoc_fn = self.self_type_is_available(); | |||
if !self.self_type_is_available() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably causes a regression in the suggestions for the code:
struct Foo {
i: i32,
}
impl Foo {
fn needs_self() {
this.i
}
}
Which currently looks like:
error[[E0425]](https://doc.rust-lang.org/stable/error-index.html#E0425): cannot find value `this` in this scope
--> src/lib.rs:7:9
|
7 | this.i
| ^^^^ not found in this scope
|
help: you might have meant to use `self` here instead
|
7 | self.i
| ~~~~
help: if you meant to use `self`, you are also missing a `self` receiver argument
|
6 | fn needs_self(&self) {
| +++++
Can you check that it still works? Also useful to commit a test for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This testcase still works, I didn't change the meaning of suggest_self_or_self_ref
, I moved the check from L388 to beginning of this function, removed a variable is_assoc_fn
.
I will add this code into tests.
@bors r+ |
…tebank Suggest calling the instance method of the same name when method not found Fixes rust-lang#103474
…tebank Suggest calling the instance method of the same name when method not found Fixes rust-lang#103474
…earth Rollup of 8 pull requests Successful merges: - rust-lang#95292 (Allow specialized const trait impls.) - rust-lang#100386 (Make `Sized` coinductive, again) - rust-lang#102215 (Implement the `+whole-archive` modifier for `wasm-ld`) - rust-lang#103468 (Fix unused lint and parser caring about spaces to won't produce invalid code) - rust-lang#103531 (Suggest calling the instance method of the same name when method not found) - rust-lang#103960 (piece of diagnostic migrate) - rust-lang#104051 (update Miri) - rust-lang#104129 (rustdoc: use javascript to layout notable traits popups) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
…tebank Suggest calling the instance method of the same name when method not found Fixes rust-lang#103474
…earth Rollup of 8 pull requests Successful merges: - rust-lang#95292 (Allow specialized const trait impls.) - rust-lang#100386 (Make `Sized` coinductive, again) - rust-lang#102215 (Implement the `+whole-archive` modifier for `wasm-ld`) - rust-lang#103468 (Fix unused lint and parser caring about spaces to won't produce invalid code) - rust-lang#103531 (Suggest calling the instance method of the same name when method not found) - rust-lang#103960 (piece of diagnostic migrate) - rust-lang#104051 (update Miri) - rust-lang#104129 (rustdoc: use javascript to layout notable traits popups) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Fixes #103474