Rollup of 6 pull requests #103213
Merged
Rollup of 6 pull requests #103213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The two rules within it can and should be done without the separate
media query:
* There ain't no rule saying a viewport can't be `700.5px` wide, since
hardware pixels can be finer than CSS pixels.
* The rule for the first example-wrap child should probably apply
on mobile.
* The rule for the source sidebar is overriden by the mobile rule
setting `max-width: 100vw`, so it can be merged with the rest
of the styles.
Since it's possible to have a 700.5px viewport width, the JS needs to not switch to mobile mode in such a setup.
…u-se
doc: rewrite doc for uint::{carrying_add,borrowing_sub}
Reword the documentation for bigint helper methods `uint::{carrying_add,borrowing_sub}` (rust-lang#85532).
The examples were also rewritten to demonstrate how the methods can be used in bignum arithmetic. No loops are used in the examples, but the variable names were chosen to include indices so that it is clear how this can be used in a loop if required.
Also, previously `carrying_add` had an example to say that if the input carry is false, the method is equivalent to `overflowing_add`. While the note was kept, the example was removed and an extra note was added to make sure this equivalence is not assumed for signed integers as well.
…r=m-ou-se More slice::partition_point examples After seeing the discussion of `binary_search` vs `partition_point` in rust-lang#101999, I thought some more example code could be helpful.
…h, r=GuillaumeGomez
rustdoc: remove CSS `@media (min-width: 701px)`
The two rules within it can and should be done without the separate media query:
* There ain't no rule saying a viewport can't be `700.5px` wide, since hardware pixels can be finer than CSS pixels.
<details><summary>Screenshot</summary>
</details>
* The rule for the first example-wrap child should probably apply on mobile.
<details><summary>Screenshots</summary>
## Before
## After
</details>
* The rule for the source sidebar is overriden by the mobile rule setting `max-width: 100vw`, so it can be merged with the rest of the styles.
… r=notriddle Clean up code-color and headers-color rustdoc GUI tests r? ``@notriddle``
…ondition, r=Amanieu Retrieve LLVM version from llvm-filecheck binary if it is not set yet In `rustc_codegen_gcc`, we run the `ASM` test suite. The problem is that, if a too recent version of the `llvm-filecheck` binary is provided, an extra argument needs to be passed and the to detect this version, it currently only expects a `--llvm-version` argument. With this, the version can be determined directly from the `llvm-filecheck` binary. r? ``@Amanieu``
Add some more autolabels
rustbot
added
T-libs
|
@bors r+ rollup=never p=6 |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit e0c162f with merge 9c3971522735a3377260924515a6cbdadd0ef317... |
|
💥 Test timed out |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: previous master: 2efc90e738 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (415d8fc): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Footnotes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
@media (min-width: 701px)#103164 (rustdoc: remove CSS@media (min-width: 701px))Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup