Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up rust-logo rustdoc GUI test #103054

Merged
merged 1 commit into from
Oct 15, 2022
Merged

Clean up rust-logo rustdoc GUI test #103054

merged 1 commit into from
Oct 15, 2022

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Oct 14, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 14, 2022
@notriddle
Copy link
Contributor

@bors r+ rollup

#93784 (comment)

@bors
Copy link
Contributor

bors commented Oct 14, 2022

📌 Commit 9787321 has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 14, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 14, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 14, 2022
@matthiaskrgr
Rollup merge of rust-lang#103054 - GuillaumeGomez:cleanup-rust-logo-t…
94fe5a8 
…est, r=notriddle

Clean up rust-logo rustdoc GUI test

r? `@notriddle`
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
  IMAGE: x86_64-gnu-tools
##[endgroup]
From https://github.com/rust-lang/rust
 * branch              master     -> FETCH_HEAD
Searching for toolstate changes between 32717603f61a566ff0b8293ef3177cb7c4f50fa9 and 0c8e8b5f8195fea8366c0a15407151a1551101f4
Rustdoc was updated
##[group]Run src/ci/scripts/verify-channel.sh
src/ci/scripts/verify-channel.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
---
.......... (70/78)
........   (78/78)


/checkout/src/test/rustdoc-gui/basic-code.goml basic-code... FAILED
[ERROR] (line 3) expected 1 elements, found 0: for command `assert-count: (".src-line-numbers", 1)`
Build completed unsuccessfully in 0:02:19

@matthiaskrgr matthiaskrgr mentioned this pull request Oct 14, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 14, 2022
@bors
Auto merge of rust-lang#103069 - matthiaskrgr:rollup-xxsx6sk, r=matth…
8147e6e 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#102092 (refactor: use grep -E/-F instead of fgrep/egrep)
 - rust-lang#102781 (Improved documentation for `std::io::Error`)
 - rust-lang#103017 (Avoid dropping TLS Key on sgx)
 - rust-lang#103039 (checktools: fix comments)
 - rust-lang#103045 (Remove leading newlines from integer primitive doc examples)
 - rust-lang#103047 (Update browser-ui-test version to fix some flaky tests)
 - rust-lang#103054 (Clean up rust-logo rustdoc GUI test)
 - rust-lang#103059 (Fix `Duration::{try_,}from_secs_f{32,64}(-0.0)`)
 - rust-lang#103067 (More alphabetical sorting)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 62a9c32 into rust-lang:master Oct 15, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 15, 2022
@GuillaumeGomez GuillaumeGomez deleted the cleanup-rust-logo-test branch October 15, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@notriddle notriddle

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.
6 participants
@GuillaumeGomez @notriddle @bors @rust-log-analyzer @rust-highfive @rustbot