Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only test duplicate inherent impl items in a single place #102856

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Only test duplicate inherent impl items in a single place #102856

merged 1 commit into from
Oct 14, 2022

Conversation

cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Oct 9, 2022

Based on #100387

r? @petrochenkov

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 9, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 9, 2022
@cjgillot cjgillot mentioned this pull request Oct 9, 2022
Merged
@petrochenkov
Copy link
Contributor

Blocked on #100387.

@petrochenkov petrochenkov added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 10, 2022
@cjgillot cjgillot force-pushed the impl-single-check branch 2 times, most recently from dd4e2f4 to 53c3de1 Compare October 11, 2022 06:30
@cjgillot cjgillot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Oct 11, 2022
@petrochenkov
Copy link
Contributor

r=me after rebase.
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 13, 2022
@cjgillot
Copy link
Contributor Author

@bors r=petrochenkov

@bors
Copy link
Contributor

bors commented Oct 13, 2022

📌 Commit 112ce80 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 13, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Oct 14, 2022
@Dylan-DPC
Rollup merge of rust-lang#102856 - cjgillot:impl-single-check, r=petr…
cabb57e 
…ochenkov

Only test duplicate inherent impl items in a single place

Based on rust-lang#100387

r? `@petrochenkov`
@Dylan-DPC Dylan-DPC mentioned this pull request Oct 14, 2022
Closed
@Dylan-DPC Dylan-DPC mentioned this pull request Oct 14, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 14, 2022
@bors
Auto merge of rust-lang#103048 - Dylan-DPC:rollup-47r62js, r=Dylan-DPC
9b0a099 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#102847 (impl AsFd and AsRawFd for io::{Stdin, Stdout, Stderr}, not the sys versions)
 - rust-lang#102856 (Only test duplicate inherent impl items in a single place)
 - rust-lang#102914 (Migrate css highlight without change)
 - rust-lang#102938 (Move some tests to more reasonable directories)
 - rust-lang#103015 (fix a typo)
 - rust-lang#103018 (More dupe word typos)
 - rust-lang#103025 (rustdoc: remove unused CSS `.search-container > *`)
 - rust-lang#103031 (Suppress irrefutable let patterns lint for prefixes in match guards)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
albertlarsan68 added a commit to albertlarsan68/rust that referenced this pull request Oct 14, 2022
@albertlarsan68
Rollup merge of rust-lang#103048 - Dylan-DPC:rollup-47r62js, r=Dylan-DPC
97b0ece 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#102847 (impl AsFd and AsRawFd for io::{Stdin, Stdout, Stderr}, not the sys versions)
 - rust-lang#102856 (Only test duplicate inherent impl items in a single place)
 - rust-lang#102914 (Migrate css highlight without change)
 - rust-lang#102938 (Move some tests to more reasonable directories)
 - rust-lang#103015 (fix a typo)
 - rust-lang#103018 (More dupe word typos)
 - rust-lang#103025 (rustdoc: remove unused CSS `.search-container > *`)
 - rust-lang#103031 (Suppress irrefutable let patterns lint for prefixes in match guards)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b4906ac into rust-lang:master Oct 14, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 14, 2022
@cjgillot cjgillot deleted the impl-single-check branch October 14, 2022 15:26
@Undin
Copy link
Contributor

Undin commented Jan 5, 2023 •
edited
Loading

It seems that these changes add a bug. Now the compiler produces E0592 for inherent impls instead of E0201 even if items with duplicate names are inside single impl block. Although description of E0592 says that it should be reported only when items are defined in different blocks
@cjgillot @petrochenkov could you check if I'm right?

@Undin Undin mentioned this pull request Jan 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.
6 participants
@cjgillot @petrochenkov @bors @Undin @rust-highfive @rustbot