Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ParamEnv from uninhabited query #102660

Merged
merged 1 commit into from
Oct 23, 2022
Merged

Remove ParamEnv from uninhabited query #102660

merged 1 commit into from
Oct 23, 2022

Conversation

camsteffen
Copy link
Contributor

@camsteffen camsteffen commented Oct 4, 2022 •
edited
Loading

No description provided.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 4, 2022
@rust-highfive
Copy link
Collaborator

r? @TaKO8Ki

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 4, 2022
@camsteffen
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 4, 2022
@bors
Copy link
Contributor

bors commented Oct 4, 2022

⌛ Trying commit 9a94ddc6ea4ec8caaae54de317870c1c8379bb1f with merge b6d0f43b6b1f1c9b4e24f9364b3747d49fd0ac97...

@bors
Copy link
Contributor

bors commented Oct 4, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 4, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@camsteffen
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@bors
Copy link
Contributor

bors commented Oct 4, 2022

⌛ Trying commit 648e315ea1abb9834e812dd8a19542856fb0343d with merge f94c9a60d2c79a1e8a0c6f84e58cfaab33539110...

@bors
Copy link
Contributor

bors commented Oct 4, 2022

☀️ Try build successful - checks-actions
Build commit: f94c9a60d2c79a1e8a0c6f84e58cfaab33539110 (f94c9a60d2c79a1e8a0c6f84e58cfaab33539110)

@rust-timer
Copy link
Collaborator

Queued f94c9a60d2c79a1e8a0c6f84e58cfaab33539110 with parent ead49f0, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f94c9a60d2c79a1e8a0c6f84e58cfaab33539110): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -3.0% [-3.0%, -3.0%] 1
Improvements ✅
(secondary)		 -4.1% [-5.2%, -2.1%] 3
All ❌✅ (primary) -3.0% [-3.0%, -3.0%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 2.7% [1.5%, 4.0%] 8
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 2.7% [1.5%, 4.0%] 8

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Oct 4, 2022
@camsteffen camsteffen marked this pull request as draft October 4, 2022 20:09
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@camsteffen
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 4, 2022
@bors
Copy link
Contributor

bors commented Oct 20, 2022

☀️ Try build successful - checks-actions
Build commit: bfaf2ef32d6643a0c87661565c15e4db8aa203c4 (bfaf2ef32d6643a0c87661565c15e4db8aa203c4)

@rust-timer
Copy link
Collaborator

Queued bfaf2ef32d6643a0c87661565c15e4db8aa203c4 with parent 53728ff, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (bfaf2ef32d6643a0c87661565c15e4db8aa203c4): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.1% [0.1%, 1.4%] 7
Improvements ✅
(primary)		 -0.2% [-0.3%, -0.2%] 5
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.2% [-0.3%, -0.2%] 5

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Footnotes

  1. the arithmetic mean of the percent change ↩

  2. number of relevant changes ↩

@rustbot rustbot added perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Oct 20, 2022
@camsteffen
Copy link
Contributor Author

Started a zulip thread about perf.

@camsteffen
Copy link
Contributor Author

I just put in some tweaks to InhabitedPredicate::reduce_and/reduce_or but I don't expect a visible difference from that.

I'm not sure if there's anything left to do. It looks like the regression is a random reversal of #102417.

@camsteffen
Copy link
Contributor Author

I'm confused about the query count increases for specializes and adt_def. Whenever I tried to observe it through debug logs, I would only see the number of executions without any increase.

@oli-obk
Copy link
Contributor

oli-obk commented Oct 22, 2022

This PR is a clear implementation improvement and taking a small (relative) hit on CTFE-stress and nothing else is alright.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 22, 2022

📌 Commit 2928e9e has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 22, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Oct 22, 2022

@bors rollup=never

Pressed return too early

@bors
Copy link
Contributor

bors commented Oct 23, 2022

⌛ Testing commit 2928e9e with merge 6c9c2d8...

@bors
Copy link
Contributor

bors commented Oct 23, 2022

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 6c9c2d8 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 23, 2022
@bors bors merged commit 6c9c2d8 into rust-lang:master Oct 23, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 23, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6c9c2d8): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.5% [1.2%, 1.7%] 7
Improvements ✅
(primary)		 -0.2% [-0.2%, -0.2%] 2
Improvements ✅
(secondary)		 -1.2% [-1.2%, -1.2%] 3
All ❌✅ (primary) -0.2% [-0.2%, -0.2%] 2

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.4% [-1.4%, -1.4%] 3
Improvements ✅
(secondary)		 -2.4% [-3.0%, -1.9%] 13
All ❌✅ (primary) -1.4% [-1.4%, -1.4%] 3

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

@camsteffen camsteffen deleted the uninhabited-perf branch October 23, 2022 12:54
@camsteffen camsteffen mentioned this pull request Oct 23, 2022
Merged
@pnkfelix
Copy link
Member

Weird, perf flagged this as mixed but I do not know why; all the regressions are to secondary benchmarks, and I had thought in that scenario we would mark this as strict improvement.

Anyway, as noted above:

This PR is a clear implementation improvement and taking a small (relative) hit on CTFE-stress and nothing else is alright.

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Oct 26, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 21, 2022
@bors
Auto merge of rust-lang#103454 - camsteffen:remove-conservatively-uni…
736c675 
…nhabited, r=oli-obk

Factor out `conservative_is_privately_uninhabited`

After rust-lang#102660 there is no more need for `conservative_is_privately_uninhabited`.

r? `@oli-obk`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

Assignees

@TaKO8Ki TaKO8Ki

Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.
9 participants
@camsteffen @rust-highfive @rust-timer @bors @rust-log-analyzer @oli-obk @pnkfelix @TaKO8Ki @rustbot