Add tests for static async functions in traits #102642

bryangarza · 2022-10-04T01:37:34Z

This patch adds test cases for AFIT, the majority of which are currently expected to run as check-fail.

Note: I grabbed the cases from https://hackmd.io/SwRcXCiWQV-WRJ4BYs53fA

Also, I'm not sure if the async-associated-types2 and async-associated-types2-desugared are correct, I modified them a bit from the examples in the HackMD.

rust-highfive · 2022-10-04T01:37:37Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information.

bryangarza · 2022-10-04T01:37:49Z

r? @compiler-errors

compiler-errors

Some initial comments, probably not comprehensive but wanted to do a first pass. I will take another look at it in a few days.

src/test/ui/async-await/in-trait/async-associated-types.rs

compiler-errors · 2022-10-04T01:40:47Z

src/test/ui/async-await/in-trait/async-associated-types2-desugared.rs

+    where
+        Self: 'a;
+
+    async fn foo(&self) -> Self::Fut<'a>;


Can you fix this? This should probably be &'a self (and adding 'a generic lifetime) or Self::Fut<'_>.

Suggested change

async fn foo(&self) -> Self::Fut<'a>;

fn foo(&self) -> Self::Fut<'a>;

I'm not 100% sure what this test is trying to test, but the name "desugared" suggests to me that it's trying to write out explicitly the equivalent of an async fn

Can you fix this? This should probably be &'a self (and adding 'a generic lifetime) or Self::Fut<'_>.

oh, yeah that makes sense. I'll update it

@spastorino what did you have in mind for this one (example 10 in your HackMD)? I know what desugared means in a general sense, not sure what that would look like for this though.

Actually, I understand now, after re-reading the static AFIT RFC

src/test/ui/async-await/in-trait/async-associated-types2.rs

src/test/ui/async-await/in-trait/async-generics-and-bounds.rs

src/test/ui/async-await/in-trait/async-generics.rs

src/test/ui/async-await/in-trait/async-lifetimes-and-bounds.rs

src/test/ui/async-await/in-trait/fn-not-async-err2.rs

nikomatsakis

Gave a quick skim, though not over everything. Some questions!

src/test/ui/async-await/in-trait/async-associated-types.rs

nikomatsakis · 2022-10-04T15:06:12Z

src/test/ui/async-await/in-trait/async-associated-types2-desugared.rs

+    where
+        Self: 'a;
+
+    async fn foo(&self) -> Self::Fut<'a>;


Suggested change

async fn foo(&self) -> Self::Fut<'a>;

fn foo(&self) -> Self::Fut<'a>;

I'm not 100% sure what this test is trying to test, but the name "desugared" suggests to me that it's trying to write out explicitly the equivalent of an async fn

src/test/ui/async-await/in-trait/async-associated-types.rs

src/test/ui/async-await/in-trait/async-generics-and-bounds.rs

bryangarza · 2022-10-07T16:16:13Z

Added some additional tests

compiler-errors

Left some more feedback.

src/test/ui/async-await/in-trait/async-example-desugared-boxed.rs

src/test/ui/async-await/in-trait/async-example-desugared-in-trait.rs

src/test/ui/async-await/in-trait/async-example-desugared.rs

src/test/ui/async-await/in-trait/async-example.rs

src/test/ui/async-await/in-trait/async-lifetimes.rs

src/test/ui/async-await/in-trait/fn-not-async-err2-rpitit.rs

This patch adds test cases for AFIT, the majority of which are currently expected to run as `check-fail`.

Co-authored-by: Michael Goulet <michael@errs.io>

- Add comment to some tests that will break when rust-lang#102745 is implemented - Mark a test with known-bug - Delete duplicate test

bryangarza · 2022-10-27T23:17:23Z

Thanks! I updated it now

compiler-errors · 2022-10-28T00:37:32Z

This looks good for now. @bryangarza, make sure to note what has test coverage and what doesn't for future AFIT/RPITIT test writers. Not sure if there's a hackmd already for that.

@bors r+ rollup

bors · 2022-10-28T00:37:34Z

📌 Commit bfdefdb has been approved by compiler-errors

It is now in the queue for this repository.

…errors Add tests for static async functions in traits This patch adds test cases for AFIT, the majority of which are currently expected to run as `check-fail`. --- Note: I grabbed the cases from https://hackmd.io/SwRcXCiWQV-WRJ4BYs53fA Also, I'm not sure if the `async-associated-types2` and `async-associated-types2-desugared` are correct, I modified them a bit from the examples in the HackMD.

…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#102642 (Add tests for static async functions in traits) - rust-lang#103283 (Add suggestions for unsafe impl error codes) - rust-lang#103523 (Fix unwanted merge of inline doc comments for impl blocks) - rust-lang#103550 (diagnostics: do not suggest static candidates as traits to import) - rust-lang#103641 (Don't carry MIR location in `ConstraintCategory::CallArgument`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rust-highfive assigned Mark-Simulacrum Oct 4, 2022

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 4, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 4, 2022

rust-highfive assigned compiler-errors and unassigned Mark-Simulacrum Oct 4, 2022

compiler-errors reviewed Oct 4, 2022

View reviewed changes

This comment has been minimized.

Sign in to view

nikomatsakis requested changes Oct 4, 2022

View reviewed changes

This was referenced Oct 4, 2022

Compilation error for lifetimes in associated type used by async-fn-in-trait #102681

Closed

"Parameter type may not live long enough" compilation error for async-fn-in-trait #102682

Closed

compiler-errors reviewed Oct 5, 2022

View reviewed changes

src/test/ui/async-await/in-trait/async-associated-types.rs Outdated Show resolved Hide resolved

compiler-errors reviewed Oct 5, 2022

View reviewed changes

src/test/ui/async-await/in-trait/async-generics-and-bounds.rs Show resolved Hide resolved

bryangarza requested a review from compiler-errors October 27, 2022 18:57

compiler-errors requested changes Oct 27, 2022

View reviewed changes

bryangarza and others added 6 commits October 27, 2022 22:58

Add tests for static async functions in traits

97423d3

This patch adds test cases for AFIT, the majority of which are currently expected to run as `check-fail`.

Update static AFIT tests based on feedback

8a0ebca

Update tests based on feedback

11b1439

Add additional tests for static AFIT

9a05081

Update src/test/ui/async-await/in-trait/async-example.rs

0b3b046

Co-authored-by: Michael Goulet <michael@errs.io>

Update tests based on feedback

bfdefdb

- Add comment to some tests that will break when rust-lang#102745 is implemented - Mark a test with known-bug - Delete duplicate test

bryangarza force-pushed the afit-tests branch from c212812 to bfdefdb Compare October 27, 2022 23:11

bryangarza requested a review from compiler-errors October 27, 2022 23:17

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2022

This was referenced Oct 28, 2022

Rollup of 11 pull requests #103670

Closed

Rollup of 5 pull requests #103671

Merged

bors merged commit c404092 into rust-lang:master Oct 28, 2022

rustbot added this to the 1.66.0 milestone Oct 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tests for static async functions in traits #102642

Add tests for static async functions in traits #102642

bryangarza commented Oct 4, 2022

rust-highfive commented Oct 4, 2022

bryangarza commented Oct 4, 2022

compiler-errors left a comment

compiler-errors Oct 4, 2022

nikomatsakis Oct 4, 2022

bryangarza Oct 4, 2022

bryangarza Oct 4, 2022 •

edited

Loading

bryangarza Oct 7, 2022

This comment has been minimized.

nikomatsakis left a comment

nikomatsakis Oct 4, 2022

bryangarza commented Oct 7, 2022

compiler-errors left a comment

bryangarza commented Oct 27, 2022

compiler-errors commented Oct 28, 2022

bors commented Oct 28, 2022

	async fn foo(&self) -> Self::Fut<'a>;
	fn foo(&self) -> Self::Fut<'a>;

Add tests for static async functions in traits #102642

Add tests for static async functions in traits #102642

Conversation

bryangarza commented Oct 4, 2022

rust-highfive commented Oct 4, 2022

bryangarza commented Oct 4, 2022

compiler-errors left a comment

Choose a reason for hiding this comment

compiler-errors Oct 4, 2022

Choose a reason for hiding this comment

nikomatsakis Oct 4, 2022

Choose a reason for hiding this comment

bryangarza Oct 4, 2022

Choose a reason for hiding this comment

bryangarza Oct 4, 2022 • edited Loading

Choose a reason for hiding this comment

bryangarza Oct 7, 2022

Choose a reason for hiding this comment

This comment has been minimized.

nikomatsakis left a comment

Choose a reason for hiding this comment

nikomatsakis Oct 4, 2022

Choose a reason for hiding this comment

bryangarza commented Oct 7, 2022

compiler-errors left a comment

Choose a reason for hiding this comment

bryangarza commented Oct 27, 2022

compiler-errors commented Oct 28, 2022

bors commented Oct 28, 2022

bryangarza Oct 4, 2022 •

edited

Loading