Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errors: rename typeck.ftl to hir_analysis.ftl #102395

Merged
merged 1 commit into from
Oct 4, 2022
Merged

errors: rename typeck.ftl to hir_analysis.ftl #102395

merged 1 commit into from
Oct 4, 2022

Conversation

davidtwco
Copy link
Member

In #102306, rustc_typeck was renamed to rustc_hir_analysis but the diagnostic resources were not renamed - which is what this pull request changes.

@davidtwco davidtwco added the A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic label Sep 28, 2022
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 28, 2022
@rustbot
Copy link
Collaborator

rustbot commented Sep 28, 2022

rustc_macros::diagnostics was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

@rust-highfive
Copy link
Collaborator

r? @jackh726

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 28, 2022
@rust-log-analyzer

This comment was marked as resolved.

Sign in to view
@davidtwco davidtwco force-pushed the translation-rename-typeck branch from efa0823 to 715d61d Compare September 28, 2022 10:17
JohnTitor
JohnTitor approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me 👍

@estebank
Copy link
Contributor

r? @estebank

@bors r+

@bors
Copy link
Contributor

bors commented Sep 28, 2022

📌 Commit 715d61d has been approved by estebank

It is now in the queue for this repository.

@rust-highfive rust-highfive assigned estebank and unassigned jackh726 Sep 28, 2022
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Sep 28, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 28, 2022
@Dylan-DPC
Rollup merge of rust-lang#102395 - davidtwco:translation-rename-typec…
51743a2 
…k, r=estebank

errors: rename `typeck.ftl` to `hir_analysis.ftl`

In rust-lang#102306, `rustc_typeck` was renamed to `rustc_hir_analysis` but the diagnostic resources were not renamed - which is what this pull request changes.
@JohnTitor
Copy link
Member

This may cause a failure with other PRs, so
@bors r=iffy

@bors
Copy link
Contributor

bors commented Sep 29, 2022

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Sep 29, 2022

📌 Commit 715d61d has been approved by iffy

It is now in the queue for this repository.

@JohnTitor
Copy link
Member

Sorry, wrong input!
@bors r=estebank rollup=iffy

@bors
Copy link
Contributor

bors commented Sep 29, 2022

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Sep 29, 2022

📌 Commit 715d61d has been approved by estebank

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 29, 2022

⌛ Testing commit 715d61d with merge ccb80638b2597c6d37cf0f04230416f6e5ce8ef7...

@bors

This comment was marked as resolved.

Sign in to view
@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 29, 2022
@rust-log-analyzer

This comment was marked as resolved.

Sign in to view
@davidtwco davidtwco force-pushed the translation-rename-typeck branch from 715d61d to 6a03328 Compare September 29, 2022 08:32
@bors

This comment was marked as resolved.

Sign in to view
@davidtwco
errors: rename typeck.ftl to hir_analysis.ftl
c4418e1 
In rust-lang#102306, `rustc_typeck` was renamed to `rustc_hir_analysis` but the
diagnostic resources were not renamed - which is what this commit
changes.

Signed-off-by: David Wood <david.wood@huawei.com>
@davidtwco davidtwco force-pushed the translation-rename-typeck branch from 6a03328 to c4418e1 Compare October 3, 2022 12:52
@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Oct 4, 2022

📌 Commit c4418e1 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 4, 2022
@bors
Copy link
Contributor

bors commented Oct 4, 2022

⌛ Testing commit c4418e1 with merge d9f8b4b...

@bors
Copy link
Contributor

bors commented Oct 4, 2022

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing d9f8b4b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 4, 2022
@bors bors merged commit d9f8b4b into rust-lang:master Oct 4, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 4, 2022
This was referenced Oct 4, 2022
Merged
Merged
Merged
Merged
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d9f8b4b): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.7% [-2.3%, -1.0%] 2
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Footnotes

  1. the arithmetic mean of the percent change ↩

  2. number of relevant changes ↩

@davidtwco davidtwco deleted the translation-rename-typeck branch October 4, 2022 08:25
@mejrs mejrs mentioned this pull request Oct 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees

@estebank estebank

Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.
10 participants
@davidtwco @rustbot @rust-highfive @rust-log-analyzer @estebank @bors @JohnTitor @compiler-errors @rust-timer @jackh726