Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add loongarch64 abi support #101939

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Add loongarch64 abi support #101939

merged 1 commit into from
Nov 10, 2022

Conversation

zhaixiaojuan
Copy link
Contributor

No description provided.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 17, 2022
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 17, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Sep 20, 2022

As far as I can tell this adds a new Tier 3 target.

There are instructions at https://doc.rust-lang.org/rustc/target-tier-policy.html#tier-3-target-policy for the conditions that need to be met in order to add such a target.

Please create an MCP for adding the new target.

@apiraino
Copy link
Contributor

apiraino commented Nov 9, 2022

The MCP is rust-lang/compiler-team#518 and is now accepted. Can this PR be reviewed or are there other middle steps?

Also, what's the relationship between this PR and #96971? Should they progress together? Should they share the reviewers (i.e. same people having the context)?

thanks

@oli-obk
Copy link
Contributor

oli-obk commented Nov 10, 2022

@bors r+

Seems fine to merge this now and deduplicate later

@bors
Copy link
Contributor

bors commented Nov 10, 2022

📌 Commit c7961da has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 10, 2022
@Manishearth Manishearth mentioned this pull request Nov 10, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 10, 2022
@bors
Auto merge of rust-lang#104246 - Manishearth:rollup-9o3txc7, r=Manish…
a3c0a02 
…earth

Rollup of 9 pull requests

Successful merges:

 - rust-lang#101939 (Add loongarch64 abi support)
 - rust-lang#103863 (Use `TraitEngine` in more places, restrict visibility of `FulfillmentCtxt` constructor)
 - rust-lang#104036 (Suggest `is_some` when we've found `Option` but expected `bool`)
 - rust-lang#104060 (Make `Hash`, `Hasher` and `BuildHasher` `#[const_trait]` and make `Sip` const `Hasher`)
 - rust-lang#104077 (Use aapcs for efiapi calling convention on arm)
 - rust-lang#104186 (Tighten the 'introduce new binding' suggestion)
 - rust-lang#104194 (`EarlyBinder` docs)
 - rust-lang#104233 (Don't ICE when encountering `ConstKind::Error` in `RequiredConstsVisitor`)
 - rust-lang#104235 (Use `const_error_with_guaranteed` more)

Failed merges:

 - rust-lang#104078 (Print "Checking/Building ..." message even when --dry-run is passed)
 - rust-lang#104169 (Migrate `:target` rules to use CSS variables)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a7cd4f2 into rust-lang:master Nov 10, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 10, 2022
@xen0n
Copy link
Contributor

xen0n commented Nov 17, 2022

@zhaixiaojuan: Please kindly cc me for further LoongArch changes.

In this PR you used the RISC-V terminology "XLEN" and "FLEN", while they should be "GRLen" and "FRLen" respectively for LoongArch, even if they're actually analogues (with the LoongArch taking the concept from RISC-V). Fortunately the rest looks correct.

@zhaixiaojuan
Copy link
Contributor Author

@zhaixiaojuan: Please kindly cc me for further LoongArch changes.

In this PR you used the RISC-V terminology "XLEN" and "FLEN", while they should be "GRLen" and "FRLen" respectively for LoongArch, even if they're actually analogues (with the LoongArch taking the concept from RISC-V). Fortunately the rest looks correct.

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.
7 participants
@zhaixiaojuan @rust-highfive @oli-obk @apiraino @bors @xen0n @rustbot