-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 4 pull requests #101396
Rollup of 4 pull requests #101396
Commits on Aug 29, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 1383f0e - Browse repository at this point
Copy the full SHA 1383f0eView commit details
Commits on Sep 3, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 12a4952 - Browse repository at this point
Copy the full SHA 12a4952View commit details -
Configuration menu - View commit details
-
Copy full SHA for e9b01c7 - Browse repository at this point
Copy the full SHA e9b01c7View commit details -
rustdoc: remove
.impl-items { flex-basis }
CSS, not in flex containerAdded in 34bd2b8 For this to actually do anything, [according to MDN] (and Firefox Dev Tools), it must be a "flex item", which only happens if its a direct child of a node with `display: flex` on it. It seems like it could not have worked at the time when this rule was added, because the only items in `rustdoc.css` with `display: flex` active were: * `#help` This should not contain anything like this. * `.impl-items h4, h4.impl, h3.impl` These are all headers, so they shouldn't contain `.impl-items` either. * `.content .impl-items .method, .content .impl-items > .type, .impl-items > .associatedconstant` Associated constants and methods definitely shouldn't contain a list of impl items, and the `.type` class seems to refer to type aliases, which, when shown inside of an impl, only show a link to the aliased type. [according to MDN]: https://developer.mozilla.org/en-US/docs/Web/CSS/flex-basis Nowadays, `display: flex` is a lot more prolific, but `.impl-items` still seems to only be used in plain block parents: * If it's not a trait impl, then it's nested below a `<div>` with an id but no class, added in a5216cf. This will be `display: block`, probably. For example, [vec deref] * Inherent impls also get a `<div>` tag, for example [vec impl], and they are also wrapped by their own non-flexbox `<details>` tag. * If it's a tait implementation, then it's also nested below a `<details>` container, like [deref cstring]. [vec impl]: https://doc.rust-lang.org/1.63.0/std/vec/struct.Vec.html#impl [vec deref]: https://doc.rust-lang.org/1.63.0/std/vec/struct.Vec.html#deref-methods-%5BT%5D [deref cstring]: https://doc.rust-lang.org/1.63.0/std/ops/trait.Deref.html#impl-Deref Also, this would imply that trait items ought to take up as much space as possible, pushing everything else to the edge of the screen. If this is nested directly below the `.rustdoc` container, which has a row basis, that would be bad.
Configuration menu - View commit details
-
Copy full SHA for cee90dd - Browse repository at this point
Copy the full SHA cee90ddView commit details -
Rollup merge of rust-lang#100302 - compiler-errors:deref-path-methods…
…, r=jackh726 Suggest associated method on deref types when path syntax method fails Fixes rust-lang#100278
Configuration menu - View commit details
-
Copy full SHA for bd9750f - Browse repository at this point
Copy the full SHA bd9750fView commit details -
Rollup merge of rust-lang#100647 - obeis:issue-99875, r=nagisa
Make trait bound not satisfied specify kind Closes rust-lang#99875
Configuration menu - View commit details
-
Copy full SHA for d085194 - Browse repository at this point
Copy the full SHA d085194View commit details -
Rollup merge of rust-lang#101349 - notriddle:notriddle/flex-basis, r=…
…GuillaumeGomez rustdoc: remove `.impl-items { flex-basis }` CSS, not in flex container Added in 34bd2b8 For this to actually do anything, [according to MDN] (and Firefox Dev Tools), it must be a "flex item", which only happens if its a direct child of a node with `display: flex` on it. It seems like it could not have worked at the time when this rule was added, because the only items in `rustdoc.css` with `display: flex` active were: * `#help` This should not contain anything like this. * `.impl-items h4, h4.impl, h3.impl` These are all headers, so they shouldn't contain `.impl-items` either. * `.content .impl-items .method, .content .impl-items > .type, .impl-items > .associatedconstant` Associated constants and methods definitely shouldn't contain a list of impl items, and the `.type` class seems to refer to type aliases, which, when shown inside of an impl, only show a link to the aliased type. [according to MDN]: https://developer.mozilla.org/en-US/docs/Web/CSS/flex-basis Nowadays, `display: flex` is a lot more prolific, but `.impl-items` still seems to only be used in plain block parents: * If it's not a trait impl, then it's nested below a `<div>` with an id but no class, added in a5216cf. This will be `display: block`, probably. For example, [vec deref] * Inherent impls also get a `<div>` tag, for example [vec impl], and they are also wrapped by their own non-flexbox `<details>` tag. * If it's a tait implementation, then it's also nested below a `<details>` container, like [deref cstring]. [vec impl]: https://doc.rust-lang.org/1.63.0/std/vec/struct.Vec.html#impl [vec deref]: https://doc.rust-lang.org/1.63.0/std/vec/struct.Vec.html#deref-methods-%5BT%5D [deref cstring]: https://doc.rust-lang.org/1.63.0/std/ops/trait.Deref.html#impl-Deref Also, this would imply that trait items ought to take up as much space as possible, pushing everything else to the edge of the screen. If this is nested directly below the `.rustdoc` container, which has a row basis, that would be bad.
Configuration menu - View commit details
-
Copy full SHA for 037c979 - Browse repository at this point
Copy the full SHA 037c979View commit details -
Rollup merge of rust-lang#101369 - compiler-errors:global-asm-pprint,…
… r=jackh726 Fix `global_asm` macro pretty printing Fixes rust-lang#101051 Fixes rust-lang#101047
Configuration menu - View commit details
-
Copy full SHA for a3dda51 - Browse repository at this point
Copy the full SHA a3dda51View commit details