Capitalize statics in f32 and f64 mods #10136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ugh, did this second commit become part of the same pull request? |
|
@hatahet: yes, pull requests track branches |
|
So what do we do about this one now? :/ The good news is that it was already reviewed previously: #10085 (comment) |
|
@hatahet: you need to reset this branch back to the previous commit, and push the new commit to a new branch based on the real master |
|
I rebased, the second commit seems to have disappeared. |
|
|
||
| /// 1.0/pi | ||
| pub static frac_1_pi: f32 = 0.318309886183790671537767526745028724_f32; | ||
| pub static FRAC_1_PI: f32 = 0.318309886183790671537767526745028724_f32; | ||
|
|
||
| /// 2.0/pi | ||
| pub static frac_2_pi: f32 = 0.636619772367581343075535053490057448_f32; |
|
Would you mind squashing these to commits into one? |
|
Done! |
bors
added a commit
that referenced
this pull request
Oct 29, 2013
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 12, 2023
…t-FP, r=Manishearth don't lint field_reassign when field in closure fixes rust-lang#10136 This change makes the ContainsName struct visit all interior expressions, which means that ContainsName will return true even if `name` is used in a closure within `expr`. --- changelog: FP: [`field_reassign_with_default`]: No longer lints cases, where values are initializes from closures capturing struct values [rust-lang#10143](rust-lang/rust-clippy#10143) <!-- changelog_checked -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10077