Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mutability_errors.rs diag-mig #101301

Closed
wants to merge 4 commits into from
Closed

mutability_errors.rs diag-mig #101301

wants to merge 4 commits into from

Conversation

AndyJado
Copy link
Contributor

@AndyJado AndyJado commented Sep 2, 2022

@rustbot rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 2, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 2, 2022
davidtwco
davidtwco reviewed Sep 2, 2022
View reviewed changes
compiler/rustc_borrowck/src/diagnostics/mutability_errors.rs Outdated
@@ -1048,12 +1047,10 @@ impl<'a, 'tcx> MirBorrowckCtxt<'a, 'tcx> {
kind: hir::ImplItemKind::Fn(sig, _),
..
}) => {
//FIXME: empty string here don't pass lint
err.span_label(ident.span, "");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make a Fluent message like the following for this?

borrowck_empty_label = {""}

compiler/rustc_borrowck/src/session_diagnostics.rs Outdated
@@ -157,3 +157,44 @@ pub(crate) enum RequireStaticErr {
multi_span: MultiSpan,
},
}
//mutability_errors.rs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to have this comment here.

@AndyJado
Copy link
Contributor Author

AndyJado commented Sep 3, 2022

moved

@AndyJado AndyJado closed this Sep 3, 2022
@davidtwco davidtwco mentioned this pull request Nov 8, 2022
Open
84 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco left review comments

Assignees

@davidtwco davidtwco

Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndyJado @davidtwco @rust-highfive @rustbot