Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default trait implementations for "c-unwind" ABI function pointers #101263

Merged
merged 4 commits into from
Oct 21, 2022
Merged

Add default trait implementations for "c-unwind" ABI function pointers #101263

merged 4 commits into from
Oct 21, 2022

Commits on Oct 20, 2022

  1. Add default trait implementations for "c-unwind" ABI function pointers 

    Following up on #92964, only add default trait implementations for the
`c-unwind` family of function pointers. The previous attempt in #92964
added trait implementations for many more ABIs and ran into concerns
regarding the increase in size of the libcore rlib.

An attempt to abstract away function pointer types behind a unified
trait to reduce the duplication of trait impls is being discussed in #99531
but this change looks to be blocked on a lang MCP.

Following @RalfJung's suggestion in
#99531 (comment),
this commit is another cut at #92964 but it _only_ adds the impls for
`extern "C-unwind" fn` and `unsafe extern "C-unwind" fn`.

I am interested in landing this patch to unblock the stabilization of
the `c_unwind` feature.

RFC: rust-lang/rfcs#2945
Tracking Issue: #74990
    @lopopolo
    lopopolo committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    16dd573 View commit details
    Browse the repository at this point in the history

  2. Bless ui tests

    @lopopolo
    lopopolo committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    d0a33f2 View commit details
    Browse the repository at this point in the history

  3. Update stability annotations on fnptr impls for C-unwind ABI

    @lopopolo
    lopopolo committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    5316796 View commit details
    Browse the repository at this point in the history

  4. Skip C-unwind fn pointer impls with the bootstrap compiler 

    These need to wait until #103239 makes it into the bootstrap compiler.
    @lopopolo
    lopopolo committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    efe61da View commit details
    Browse the repository at this point in the history