⬆️ rust-analyzer #101197
Merged
⬆️ rust-analyzer #101197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This workaround avoids constant crashing of rust analyzer when using GATs with const generics, even when the const generics are only on the `impl` block. The workaround treats GATs as non-existing if either itself or the parent has const generics and removes relevant panicking code-paths.
weren't used in the end
internal: remove unnecessary stream writer try_clone in lsp-server
…ng, r=Veykril feat: make trait assoc items become inactive due to cfg fixes rust-lang#12394
Replace crossbeam with std's scoped threads Probably best to wait a week or two so we don't immediately give linux packagers problems again
fix: Fix panics on GATs involving const generics This workaround avoids constant crashing of rust analyzer when using GATs with const generics, even when the const generics are only on the `impl` block. The workaround treats GATs as non-existing if either itself or the parent has const generics and removes relevant panicking code-paths. Fixes rust-lang#11989, fixes rust-lang#12193
Pop an error notification when flycheck can't be restarted
feat: emit SCIP from rust-analyzer hi rust-analyzer team I'm one of the engineers at Sourcegraph (and have done a few small changes related to the LSIF work done in rust-analyzer). Recently, we've moved to a new protocol as the primary way to interact with Sourcegraph (LSIF is still possible to upload, so existing jobs will not stop working any time soon). This new protocol is SCIP (I linked a blog post below with more information). I've implemented SCIP support (based largely on the existing LSIF support). In addition to supporting the existing features that `rust-analyzer`'s LSIF support does, this PR adds the ability to move between crates on sourcegraph.com. So if both your project and a dependency are indexed, you would be able to hop to the particular version and view the source code. I'd be happy to record a demo of that on my local instance if you're interested. There are a few TODO's left in the code (some that you might have insights on) which I'm happy to fix in this PR, but I just wanted to open this up for discussion first. Thanks for your time :) TJ - [announcing scip](https://about.sourcegraph.com/blog/announcing-scip)
Do not substitute `Self` when in same impl block Fix rust-lang#13076
internal: Re-export standard semantic token types and mods Should help in preventing future occurences of rust-lang#13099 by having all token types and mods come through the same place
minor: Remove unused UpdatesChannel type
Make use of NoHash hashing for FileId and CrateId Both of these are mere integers so there is nothing to hash here. Ideally we would use this for `la_arena::Idx` too, but that doesn't work due to the orphan rule, and `la_arena` is unfortunately a public library so we can't really do much here... Unless we remove the trait restriction but I'd like not to
…as-schievink fix: make "Extract type as type alias" assist work with const generics in array fixes rust-lang#11197
Remove auto-config patching from the VSCode client This was introduced 4 months ago when we drastically changed the config keys. I'd like to remove this given I always felt uneasy doing edits to a users config from within r-a, and by now most if not all users should've swapped to a new enough version of r-a that should've updated their configs. The extension will continue to work fine even with the outdated keys afterwards since we still do patching server side as well, and that one we'll have to support for quite some more time (if not until a proper 1.0 release where I assume we can allow ourselves some more user facing breakage) (There also might've been a small bug in here that prevented users with certain outdated keys to prevent them from enabling certain keys for some reason)
minor: Simplify
…, r=jonas-schievink fix: Avoid error popup when using in Live Share cc rust-lang/rust-analyzer#8844 Not sure if there's a better way to do this, feedback appreciated!
Move empty diagnostics workaround back into the server This only touches on the diagnostics in one place instead of multiple as was previously done, since all published diagnostics will go through this code path anyways. Closes rust-lang/rust-analyzer#13130
|
@bors r+ rollup |
bors
added
the
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Aug 30, 2022
…r=lnicola ⬆️ rust-analyzer r? `@ghost`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 31, 2022
Rollup of 10 pull requests Successful merges: - rust-lang#100804 (Fix search results color on hover for ayu theme) - rust-lang#100892 (Add `AsFd` implementations for stdio types on WASI.) - rust-lang#100927 (Adding new Fuchsia rustup docs... reworking walkthrough) - rust-lang#101088 (Set DebuginfoKind::Pdb in msvc_base) - rust-lang#101159 (add tracking issue number to const_slice_split_at_not_mut) - rust-lang#101192 (Remove path string) - rust-lang#101193 (Avoid zeroing large stack buffers in stdio on Windows) - rust-lang#101197 (:arrow_up: rust-analyzer) - rust-lang#101200 (Add test for issue rust-lang#85872) - rust-lang#101219 (Update books) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @ghost